Fix pip state pip >=10.0 and <=18.0 #54807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using pip versions between 10.0 and 18.1, the import of the _internal modules in pip_state will fail. Ref pip 10.0.0b1 release notes: https://pip.pypa.io/en/stable/news/#b1-2018-03-31 This PR changes 18.1 to 10.0
Revert change for pip._internal.req.constructors version query.
s0undt3ch
approved these changes
Sep 29, 2019
twangboy
approved these changes
Sep 30, 2019
garethgreenaway
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the work from #54772 and adds tests
What does this PR do?
When using pip versions between 10.0 and 18.0, the import of the pip.exceptions modules in pip_state will fail, as it was moved to pip._internal.exceptions in pip version 10.0.
Ref pip 10.0.0b1 release notes:
https://pip.pypa.io/en/stable/news/#b1-2018-03-31
What issues does this PR fix or reference?
#54762
Previous Behavior
pip.installed state will fail to load with pip >=10.0 and <=18.0
New Behavior
pip.installed state will load with pip >=10.0 and <=18.0
Tests written?
Yes
Commits signed with GPG?
Yes