Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignores config/dependency-lint in an addon #16

Open
BryanCrotaz opened this issue Feb 20, 2019 · 3 comments
Open

ignores config/dependency-lint in an addon #16

BryanCrotaz opened this issue Feb 20, 2019 · 3 comments

Comments

@BryanCrotaz
Copy link

BryanCrotaz commented Feb 20, 2019

Getting version conflict issues for ember-assign-polyfill. Tried putting config in main addon and in dummy app, with no difference.

Tried both of these:

'use strict';
module.exports={
  generateTests: false
}
'use strict';
module.exports={
  allowedVersions: {
    'ember-assign-polyfill': '*'
  }
}

I still get a failing test in both versions.

ember-cli 3.7.1
ember-cli-dependency-lint: 1.1.3

@scottkidder
Copy link

I was able to get this working by putting the config in the dummy app. It raises a question for me though. Should this config be in the top-level config/

@BryanCrotaz
Copy link
Author

A year later and it happened to me again. Luckily google brought me back here. Any thoughts on a solution?

anehx added a commit to anehx/ember-caluma that referenced this issue Jan 5, 2021
The configuration needs to be in the dummy app config folder, see
salsify/ember-cli-dependency-lint#16. Also,
the configuration of ember-changeset and ember-changeset-validations was
obsolete since we updated this a while ago.
anehx added a commit to projectcaluma/ember-caluma that referenced this issue Jan 5, 2021
The configuration needs to be in the dummy app config folder, see
salsify/ember-cli-dependency-lint#16. Also,
the configuration of ember-changeset and ember-changeset-validations was
obsolete since we updated this a while ago.
@jelhan
Copy link

jelhan commented Nov 8, 2023

The config should be located in dummy app of an addon. The config is not for the addon but for the dummy app, which is used in testing. That gets clear when migrating to v2 addon format.

Other config files have been moved in the meantime as well: https://github.com/ember-cli/ember-addon-output/tree/v5.4.0/tests/dummy/config The root config folder does not even exists anymore in latest addon blueprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants