chore(lint): fix ember-cli-dependency-lint config #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration needs to be in the dummy app config folder, see salsify/ember-cli-dependency-lint#16. Also, the configuration of ember-changeset and ember-changeset-validations was obsolete since we updated this a while ago.
|
This PR also removes all resolutions and updates the packages needed for dependency lint to pass |
|
Oh, almost forgot why this is relevant: the configuration should configure that the dependency linter is not run as a test in the test suite but a separate command. When I configured this initially I was assuming that it works - however it didn't. This caused the linter to be run with floating dependencies which makes absolutely zero sense and broke our CI all the time. /cc @fkm-adfinis @velrest @Yelinz since y'all had quite the fight with this 😉 |
velrest
approved these changes
Jan 5, 2021
velrest
reviewed
Jan 5, 2021
Co-authored-by: Jonas Cosandey <[email protected]>
|
Awesome work @anehx 🎉 |
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration needs to be in the dummy app config folder, see salsify/ember-cli-dependency-lint#16. Also, the configuration of ember-changeset and ember-changeset-validations was obsolete since we updated this a while ago.