feat: preview a visualforce page with open command

README.md

@@ -1186,7 +1186,7 @@ OPTIONS
 
 DESCRIPTION
   Opens the specified Lightning Page in Lightning App Builder. Lightning Page files have the suffix .flexipage-meta.xml,
-   and are stored in the flexipages directory. If you specify a different type of file, this command opens your org’s
+   and are stored in the flexipages directory. If you specify a visualforce page (with a .page suffix) this command let you preview your visualforce page. If you specify a different type of file, this command opens your org’s
   home page.
 
   The file opens in your default browser.

messages/open.json

@@ -1,5 +1,5 @@
 {
-  "description": "edit a Lightning Page with Lightning App Builder\nOpens the specified Lightning Page in Lightning App Builder. Lightning Page files have the suffix .flexipage-meta.xml, and are stored in the flexipages directory. If you specify a different type of file, this command opens your org’s home page.\n\nThe file opens in your default browser.\nIf no browser-based editor is available for the selected file, this command opens your org's home page.\nTo generate a URL for the browser-based editor but not open the editor, use --urlonly.",
+  "description": "edit a Lightning Page with Lightning App Builder\nOpens the specified Lightning Page in Lightning App Builder. Lightning Page files have the suffix .flexipage-meta.xml, and are stored in the flexipages directory. \nIf you specify a Visualforce page, which has a .page suffix, the page opens in your browser so you can preview it. If you specify a different type of file, this command opens your org’s home page.\n\nThe file opens in your default browser.\nIf no browser-based editor is available for the selected file, this command opens your org's home page.\nTo generate a URL for the browser-based editor but not open the editor, use --urlonly.",
   "examples": [
     "$ sfdx force:source:open -f path/to/source",
     "$ sfdx force:source:open -r -f path/to/source",

src/commands/force/source/open.ts

@@ -61,7 +61,13 @@ export class Open extends SourceCommand {
 
   private async doOpen(): Promise<void> {
     const typeName = this.getTypeNameDefinitionByFileName(path.resolve(this.flags.sourcefile as string));
-    const openPath = typeName === 'FlexiPage' ? await this.setUpOpenPath() : await this.buildFrontdoorUrl();
+    let openPath;
+    if (typeName === 'FlexiPage' || typeName === 'ApexPage') {
+      // if it is a lightning page
+      openPath = await this.setUpOpenPath(typeName);
+    } else {
+      openPath = await this.buildFrontdoorUrl();
+    }
 
     this.openResult = await this.open(openPath);
   }
@@ -98,18 +104,24 @@ export class Open extends SourceCommand {
     return this.flags.urlonly ? result : this.openBrowser(url, result);
   }
 
-  private async setUpOpenPath(): Promise<string> {
+  private async setUpOpenPath(pageType: string): Promise<string> {
     try {
-      const flexipage = await this.org
-        .getConnection()
-        .singleRecordQuery<{ Id: string }>(
-          `SELECT id FROM flexipage WHERE DeveloperName='${path.basename(
-            this.flags.sourcefile as string,
-            '.flexipage-meta.xml'
-          )}'`,
-          { tooling: true }
-        );
-      return `/visualEditor/appBuilder.app?pageId=${flexipage.Id}`;
+      if (pageType === 'FlexiPage') {
+        const flexipage = await this.org
+          .getConnection()
+          .singleRecordQuery<{ Id: string }>(
+            `SELECT id FROM flexipage WHERE DeveloperName='${path.basename(
+              this.flags.sourcefile as string,
+              '.flexipage-meta.xml'
+            )}'`,
+            { tooling: true }
+          );
+        return `/visualEditor/appBuilder.app?pageId=${flexipage.Id}`;
+      } else if (pageType === 'ApexPage') {
+        return `/apex/${path.basename(this.flags.sourcefile as string, '.page')}`;
+      } else {
+        return '_ui/flexipage/ui/FlexiPageFilterListPage';
+      }
     } catch (error) {
       return '_ui/flexipage/ui/FlexiPageFilterListPage';
     }

test/commands/source/open.test.ts

@@ -45,6 +45,19 @@ describe('force:source:open', () => {
       },
     },
   ] as SourceComponent[];
+  const apexPageComponents = [
+    {
+      name: 'MyPage',
+      type: {
+        id: 'page',
+        name: 'ApexPage',
+        suffix: 'page',
+        directoryName: 'pages',
+        inFolder: false,
+        strictDirectoryName: false,
+      },
+    },
+  ] as SourceComponent[];
   const testIp = '1.1.1.1';
   const orgId = '00DJ0000003htplMAA';
   const defaultDir = join('my', 'default', 'package');
@@ -108,6 +121,9 @@ describe('force:source:open', () => {
           if (fsPath.includes('layout')) {
             return layoutComponents;
           }
+          if (fsPath.includes('page')) {
+            return apexPageComponents;
+          }
         }
       );
       stubMethod(sandbox, MyDomainResolver.prototype, 'resolve').resolves(testIp);
@@ -140,4 +156,14 @@ describe('force:source:open', () => {
       url: `${frontDoorUrl}&retURL=${encodeURIComponent(decodeURIComponent(frontDoorUrl))}`,
     });
   });
+
+  it('given a visualforce page url return /apex/pagename', async () => {
+    const sourcefile = 'force-app/main/default/pages/MyPage.page';
+    const result = await runOpenCmd(['--sourcefile', sourcefile, '--json', '--urlonly']);
+    expect(result).to.deep.equal({
+      orgId,
+      username,
+      url: `${frontDoorUrl}&retURL=%2Fapex%2FMyPage`,
+    });
+  });
 });