feat: preview a visualforce page with open command #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @fodilo to sign the Salesforce.com Contributor License Agreement. |
|
I've signed the cla. |
Co-authored-by: Juliet Shackell <[email protected]>
jshackell-sfdc
previously requested changes
Feb 2, 2022
mshanemc
added
bug
|
Thanks for submitting! 🏆 I made some edits, so I closed this PR and started #419 from your commit. This also lets our integration tests run, which they won't do on a fork. |
Welcome thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
so it allows the preview of visualforce page directly in the browser using source:open command with .page files
What issues does this PR fix or reference?
I've created an issue about this feature https://github.com/forcedotcom/cli/issues/1386