Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/strict nulls #465

Merged
merged 18 commits into from
Jan 11, 2023
Merged

Sm/strict nulls #465

merged 18 commits into from
Jan 11, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Dec 31, 2022

requires salesforcecli/sf-plugins-core#172 and forcedotcom/source-deploy-retrieve#808 and salesforcecli/cli-plugins-testkit#370

What does this PR do?

mostly linter/ts stuff

What issues does this PR fix or reference?

@W-12285444@

Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshanemc Just a nit question

src/commands/deploy/metadata/quick.ts Show resolved Hide resolved
@peternhale
Copy link
Contributor

@mshanemc I noticed that UTs are failing for this PR

Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions - non blocking

src/utils/flags.ts Outdated Show resolved Hide resolved
src/utils/output.ts Show resolved Hide resolved
src/utils/output.ts Outdated Show resolved Hide resolved
src/utils/output.ts Show resolved Hide resolved
src/utils/types.ts Show resolved Hide resolved
src/commands/deploy/metadata.ts Show resolved Hide resolved
src/commands/deploy/metadata/preview.ts Show resolved Hide resolved
src/commands/deploy/metadata/validate.ts Show resolved Hide resolved
src/commands/retrieve/metadata/preview.ts Show resolved Hide resolved
@mshanemc mshanemc merged commit b9a5179 into main Jan 11, 2023
@mshanemc mshanemc deleted the sm/strict-nulls branch January 11, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants