Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/type-enhancements #808

Merged
merged 15 commits into from
Jan 9, 2023
Merged

Sm/type-enhancements #808

merged 15 commits into from
Jan 9, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

  1. export more of FileReponse
  2. getter on DeployRetrieve for id is types as string if the id is sure to be defined (it was passed in)
  3. directoryName is required on MetadataType (tests already ensured it was but Type has it as optional)

What issues does this PR fix or reference?

@W-12285444@

This should be types-only (no customer-facing code chagne)

@mshanemc mshanemc requested review from a team as code owners December 30, 2022 23:05
@mshanemc mshanemc mentioned this pull request Dec 31, 2022
Merged
@mshanemc mshanemc merged commit b961860 into main Jan 9, 2023
@mshanemc mshanemc deleted the sm/type-enhancements branch January 9, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

@RitamAgrawal RitamAgrawal Awaiting requested review from RitamAgrawal RitamAgrawal was automatically assigned from forcedotcom/ide-experience

@shetzel shetzel Awaiting requested review from shetzel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @peternhale @svc-cli-bot