fix(engine): issue 990 textContent and innerHTML restrictions #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
approved these changes
Jan 23, 2019
| assert.logError(`textContent is disallowed in Element unless \`lwc:dom="manual"\` directive is used in the template.`, this as Element); | ||
| } | ||
| if (this instanceof Element && options.isPortal !== true) { | ||
| assert.logError(`textContent is disallowed in Element unless \`lwc:dom="manual"\` directive is used in the template.`, this as Element); |
There was a problem hiding this comment.
Why is the this as Element typecasting necessary here?
There was a problem hiding this comment.
copy/paste, but I think we can remove it from this file since the instanceof is sufficient in ts3.x
| assert.logError(`nodeValue is disallowed in Element unless \`lwc:dom="manual"\` directive is used in the template.`, this as Element); | ||
| } | ||
| if (this instanceof Element && options.isPortal !== true) { | ||
| assert.logError(`nodeValue is disallowed in Element unless \`lwc:dom="manual"\` directive is used in the template.`, this as Element); |
There was a problem hiding this comment.
Why is the this as Element typecasting necessary here?
Benchmark resultsBase commit: lwc-engine-benchmark
|
ravijayaramappa
added a commit
that referenced
this pull request
Jan 14, 2020
ravijayaramappa
added a commit
that referenced
this pull request
Jan 20, 2020
* test: remove test for duplicate handlers restriction was removed in #1193 * test: enable test for readonly properties * test: enable test for dispatchEvent * test: remove test for removing non-existent listener on custom element * test: test setting innerHTML, outerHTML on host will throw fixed in #1001 * test: enable tests migrated to karma suite * test: more enabled tests * test: revert the suite back to disabled state * test: account for different error message across browsers * test: error message in ie11 is taken care of * fix: isConnected polyfill in IE11 fixes #987 * test: enable tests for #997 and #990 issue Tests for #997 & #990 * test: enable test for iteration fix #1285 * test: adjust error message fix #1285 * test: enable tests that work in native-shadow * test: disable non-composed event tests because of webkit bug WebKit bug - https://bugs.webkit.org/show_bug.cgi?id=206374 * fix: use regex for error message variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #990 and #991