test: test setting innerHTML, outerHTML on host will throw

fixed in #1001
salesforce · Jan 14, 2020 · 2a411c9 · 2a411c9
1 parent 0fc5937
commit 2a411c9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/packages/integration-karma/test/shadow-dom/Element-properties/Element.innerHTML.spec.js b/packages/integration-karma/test/shadow-dom/Element-properties/Element.innerHTML.spec.js
@@ -29,14 +29,13 @@ describe('Element.innerHTML - get', () => {
 });
 
 describe('Element.innerHTML - set', () => {
-    // TODO [#990]: No error is thrown when invoking innerHTML on the host element
-    xit('should throw when invoking setter on the host element', () => {
+    it('should throw when invoking setter on the host element', () => {
         const elm = createElement('x-test', { is: Test });
         document.body.appendChild(elm);
 
         expect(() => {
             elm.innerHTML = '<span>Hello World!</span>';
-        }).toThrowError();
+        }).toThrowError(TypeError);
     });
 
     it('should log an error when invoking setter for an element in the shadow', () => {

diff --git a/packages/integration-karma/test/shadow-dom/Element-properties/Element.outerHTML.spec.js b/packages/integration-karma/test/shadow-dom/Element-properties/Element.outerHTML.spec.js
@@ -29,24 +29,22 @@ describe('Element.outerHTML - get', () => {
 });
 
 describe('Element.outerHTML - set', () => {
-    // TODO [#991]: Add error type to the .toThrowError(<type>) matcher once the issue is fixed.
-    xit('should throw when invoking setter on the host element', () => {
+    it('should throw when invoking setter on the host element', () => {
         const elm = createElement('x-test', { is: Test });
         document.body.appendChild(elm);
 
         expect(() => {
             elm.outerHTML = '<span>Hello World!</span>';
-        }).toThrowError();
+        }).toThrowError(TypeError);
     });
 
-    // TODO [#991]: Add error type to the .toThrowError(<type>) matcher once the issue is fixed.
-    xit('should log an error when invoking setter for an element in the shadow', () => {
+    it('should log an error when invoking setter for an element in the shadow', () => {
         const elm = createElement('x-test', { is: Test });
         document.body.appendChild(elm);
 
         expect(() => {
             const div = elm.shadowRoot.querySelector('div');
             div.outerHTML = '<span>Hello World!</span>';
-        }).toThrowError();
+        }).toThrowError(TypeError);
     });
 });
diff --git a/...ages/integration-karma/test/shadow-dom/ShadowRoot-properties/ShadowRoot.innerHTML.spec.js b/...ages/integration-karma/test/shadow-dom/ShadowRoot-properties/ShadowRoot.innerHTML.spec.js
@@ -13,8 +13,7 @@ describe('ShadowRoot.innerHTML', () => {
         );
     });
 
-    // TODO [#991]: No error is thrown when invoking
-    xit('should throw an error when invoking setter on the shadowRoot', () => {
+    it('should throw an error when invoking setter on the shadowRoot', () => {
         const elm = createElement('x-test', { is: Test });
         document.body.appendChild(elm);