Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test failure for directive-for-each #1285

Closed
ekashida opened this issue May 28, 2019 · 0 comments · Fixed by #1674
Closed

Investigate test failure for directive-for-each #1285

ekashida opened this issue May 28, 2019 · 0 comments · Fixed by #1674

Comments

@ekashida
Copy link
Member

lwc/packages/integration-karma/test/template/directive-for-each/index.spec.js

Line 61 in 37f8cf2

// TODO: revisit

Test fails with error:

Expected function to throw an exception with a message matching /Invalid template iteration for value `\[object Object\]` in \[object:vm undefined \(\d+\)\]. It must be an array-like object and not `null` nor `undefined`./, but it threw an exception with message 'iterable[SymbolIterator] is not a function. (In 'iterable[SymbolIterator]()', 'iterable[SymbolIterator]' is undefined)'.
@ravijayaramappa ravijayaramappa mentioned this issue Jan 15, 2020
Merged
ravijayaramappa added a commit that referenced this issue Jan 15, 2020
@ravijayaramappa
test: enable test for iteration
a123af6 
fix #1285
ravijayaramappa added a commit that referenced this issue Jan 15, 2020
@ravijayaramappa
test: adjust error message
fe4cadf 
fix #1285
ravijayaramappa added a commit that referenced this issue Jan 20, 2020
@ravijayaramappa
test: enable karma tests - W-7102286 (#1674)
1f0b088 
* test: remove test for duplicate handlers

restriction was removed in #1193

* test: enable test for readonly properties

* test: enable test for dispatchEvent

* test: remove test for removing non-existent listener on custom element

* test: test setting innerHTML, outerHTML on host will throw

fixed in #1001

* test: enable tests migrated to karma suite

* test: more enabled tests

* test: revert the suite back to disabled state

* test: account for different error message across browsers

* test: error message in ie11 is taken care of

* fix: isConnected polyfill in IE11

fixes #987

* test: enable tests for #997 and #990 issue

Tests for #997 & #990

* test: enable test for iteration

fix #1285

* test: adjust error message

fix #1285

* test: enable tests that work in native-shadow

* test: disable non-composed event tests because of webkit bug

WebKit bug - https://bugs.webkit.org/show_bug.cgi?id=206374

* fix: use regex for error message variants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: enable karma tests - W-7102286 salesforce/lwc
1 participant
@ekashida