This repository was archived by the owner on Jan 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Add app ID to state #4
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
67b760d
Get id from query params
Cloud11PL b713fa6
Update readme
Cloud11PL 42a2617
Require app ID
Cloud11PL b7ed7e7
Update tests
Cloud11PL ec162f1
Cleanup id initialisation
Cloud11PL d4c0483
Export types
Cloud11PL ab1799c
Fix types
Cloud11PL 9bb248d
Change id let to const
Cloud11PL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import createApp from "."; | ||
import { AppBridgeState } from "./app"; | ||
|
||
export type App = ReturnType<typeof createApp>; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a fan of this, explicitly typing return type by |
||
export { AppBridgeState }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ Object.defineProperty(window.document, "referrer", { | |
import { actions, DispatchResponseEvent, createApp } from "../src"; | ||
|
||
describe("createApp", () => { | ||
const domain = "test-domain"; | ||
const domain = "http://test-domain.com/?id=appid"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in dashboard we have |
||
const app = createApp(domain); | ||
|
||
it("correctly sets the domain", () => { | ||
|
@@ -75,6 +75,7 @@ describe("createApp", () => { | |
expect(callback).toHaveBeenCalledTimes(1); | ||
expect(callback).toHaveBeenCalledWith(payload); | ||
expect(app.getState().token).toEqual(token); | ||
expect(app.getState().id).toEqual("appid"); | ||
|
||
// unsubscribe | ||
unsubscribe(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of that should we have
id = url.searchParams.get("id")
inelse
clause above?