This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Add app ID to state #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cloud11PL
commented
Apr 12, 2022
•
Cloud11PL
commented
- Exposes app ID in state (that is passed as a query param) - used by https://github.com/saleor/saleor-app-marketplace/pull/19
size-limit report 📦
|
Cloud11PL
force-pushed
the
SALEOR-6434-add-app-id-to-state
branch
5 times, most recently
from
aaf241e to
52db21a
Compare
Cloud11PL
force-pushed
the
SALEOR-6434-add-app-id-to-state
branch
from
52db21a to
b713fa6
Compare
Cloud11PL
force-pushed
the
SALEOR-6434-add-app-id-to-state
branch
from
e018fd8 to
42a2617
Compare
Cloud11PL
force-pushed
the
SALEOR-6434-add-app-id-to-state
branch
from
7ec8458 to
d4c0483
Compare
5 tasks
jwm0
approved these changes
Apr 14, 2022
dominik-zeglen
approved these changes
Apr 14, 2022
src/index.ts
Outdated
| @@ -12,7 +12,9 @@ export function createApp(targetDomain?: string) { | |||
| domain = url.searchParams.get("domain") || ""; | |||
| } | |||
|
|
|||
| app.setState({ domain }); | |||
| id = new URL(domain).searchParams.get("id") ?? ""; | |||
There was a problem hiding this comment.
Nitpick but it's not changed anywhere
Suggested change
| id = new URL(domain).searchParams.get("id") ?? ""; | |
| const id = new URL(domain).searchParams.get("id") ?? ""; |
| import createApp from "."; | ||
| import { AppBridgeState } from "./app"; | ||
|
|
||
| export type App = ReturnType<typeof createApp>; |
There was a problem hiding this comment.
Not a fan of this, explicitly typing return type by function createApp(): Type is making breaking api harder. Now it's possible to change function signature and no one will know until consumers start complaining about breaking changes.
magul
reviewed
Apr 15, 2022
| @@ -10,7 +10,7 @@ Object.defineProperty(window.document, "referrer", { | |||
| import { actions, DispatchResponseEvent, createApp } from "../src"; | |||
|
|
|||
| describe("createApp", () => { | |||
| const domain = "test-domain"; | |||
| const domain = "http://test-domain.com/?id=appid"; | |||
There was a problem hiding this comment.
in dashboard we have shop.domain.host passed here, isn't that just a domain (without schema)? also as you pass src={urlJoin(src, `?domain=${shop.domain.host}&id=${appId}`)} in dashboard, should that be test-domain.com&id=appid here?
| @@ -12,7 +12,9 @@ export function createApp(targetDomain?: string) { | |||
| domain = url.searchParams.get("domain") || ""; | |||
| } | |||
|
|
|||
| app.setState({ domain }); | |||
| const id = new URL(domain).searchParams.get("id") ?? ""; | |||
There was a problem hiding this comment.
instead of that should we have id = url.searchParams.get("id") in else clause above?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.