Skip to content

Commit

Permalink
Update gruvbox color themes to support inlay hint (helix-editor#6285)
Browse files Browse the repository at this point in the history
The gruvbox themes (gruvbox, gruvbox dark hard and guvbox light)
don't provide a colour for the new virtual inlay hints. Looking at the
original repo, and other derivatives, there doesn't appear to be a clear
definition of what inlay hints should be. Although most sources indicate
that it can be the same as the color for comments.

Considering that, this commit sets the new field on each of the three
themes to be gray1, same as commented text.

Signed-off-by: Josh Bainbridge <[email protected]>
joshbainbridge authored and Sagnik Bhattacharya committed Mar 21, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent 8e01469 commit 1ff93f4
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions runtime/themes/gruvbox.toml
Original file line number Diff line number Diff line change
@@ -60,6 +60,7 @@
"ui.menu.selected" = { fg = "bg2", bg = "blue1", modifiers = ["bold"] }
"ui.virtual.whitespace" = "bg2"
"ui.virtual.ruler" = { bg = "bg1" }
"ui.virtual.inlay-hint" = { fg = "gray1" }

"diagnostic.warning" = { underline = { color = "orange1", style = "curl" } }
"diagnostic.error" = { underline = { color = "red1", style = "curl" } }
1 change: 1 addition & 0 deletions runtime/themes/gruvbox_dark_hard.toml
Original file line number Diff line number Diff line change
@@ -66,6 +66,7 @@
"ui.menu.selected" = { fg = "bg2", bg = "blue1", modifiers = ["bold"] }
"ui.virtual.whitespace" = "bg2"
"ui.virtual.ruler" = { bg = "bg1" }
"ui.virtual.inlay-hint" = { fg = "gray1" }

"markup.heading" = "aqua1"
"markup.bold" = { modifiers = ["bold"] }
1 change: 1 addition & 0 deletions runtime/themes/gruvbox_light.toml
Original file line number Diff line number Diff line change
@@ -61,6 +61,7 @@
"ui.menu.selected" = { fg = "bg2", bg = "blue1", modifiers = ["bold"] }
"ui.virtual.whitespace" = "bg2"
"ui.virtual.ruler" = { bg = "bg1" }
"ui.virtual.inlay-hint" = { fg = "gray1" }

"diagnostic.warning" = { underline = { color = "orange1", style = "curl" } }
"diagnostic.error" = { underline = { color = "red1", style = "curl" } }

0 comments on commit 1ff93f4

Please sign in to comment.