Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gruvbox color themes to support inlay hint #6285

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Update gruvbox color themes to support inlay hint #6285

merged 1 commit into from
Mar 13, 2023

Conversation

joshbainbridge
Copy link
Contributor

The gruvbox themes (gruvbox, gruvbox dark hard and guvbox light) don't provide a colour for the new virtual inlay hints. Looking at the original repo, and other derivatives, there doesn't appear to be a clear definition of what inlay hints should be. Although most sources indicate that it can be the same as the color for comments.

Considering that, this commit sets the new field on each of the three themes to be gray1, same as commented text.

gruvbox old:
Screenshot 2023-03-12 at 20 42 54

gruvbox new:
Screenshot 2023-03-12 at 20 41 19

gruvbox dark hard old:
Screenshot 2023-03-12 at 20 42 59

gruvbox dark hard new:
Screenshot 2023-03-12 at 20 41 47

guvbox light old:
Screenshot 2023-03-12 at 20 43 07

guvbox light new:
Screenshot 2023-03-12 at 20 41 54

@joshbainbridge
Update gruvbox color themes to support inlay hint
c4e0fad 
The gruvbox themes (gruvbox, gruvbox dark hard and guvbox light)
don't provide a colour for the new virtual inlay hints. Looking at the
original repo, and other derivatives, there doesn't appear to be a clear
definition of what inlay hints should be. Although most sources indicate
that it can be the same as the color for comments.

Considering that, this commit sets the new field on each of the three
themes to be gray1, same as commented text.

Signed-off-by: Josh Bainbridge <[email protected]>
@the-mikedavis the-mikedavis merged commit dc418bb into helix-editor:master Mar 13, 2023
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
@joshbainbridge
Update gruvbox color themes to support inlay hint (helix-editor#6285)
1ff93f4 
The gruvbox themes (gruvbox, gruvbox dark hard and guvbox light)
don't provide a colour for the new virtual inlay hints. Looking at the
original repo, and other derivatives, there doesn't appear to be a clear
definition of what inlay hints should be. Although most sources indicate
that it can be the same as the color for comments.

Considering that, this commit sets the new field on each of the three
themes to be gray1, same as commented text.

Signed-off-by: Josh Bainbridge <[email protected]>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@joshbainbridge @wes-adams
Update gruvbox color themes to support inlay hint (helix-editor#6285)
f9820b0 
The gruvbox themes (gruvbox, gruvbox dark hard and guvbox light)
don't provide a colour for the new virtual inlay hints. Looking at the
original repo, and other derivatives, there doesn't appear to be a clear
definition of what inlay hints should be. Although most sources indicate
that it can be the same as the color for comments.

Considering that, this commit sets the new field on each of the three
themes to be gray1, same as commented text.

Signed-off-by: Josh Bainbridge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshbainbridge @the-mikedavis