Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with native-tls instead of rustls #258

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Allow building with native-tls instead of rustls #258

merged 1 commit into from
Jul 21, 2022

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Jul 20, 2022

Bundling (static linking) TLS library is a very bad idea from a security perspective and linux distributions try to avoid it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #258 (12e387e) into master (728bf25) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   94.21%   94.20%   -0.01%     
==========================================
  Files         454      454              
  Lines       16341    16343       +2     
==========================================
+ Hits        15395    15396       +1     
- Misses        946      947       +1     
Impacted Files Coverage Δ
duckscript_sdk/src/sdk/std/net/ftp/get/mod.rs 89.28% <0.00%> (-1.79%) ⬇️
duckscript_sdk/src/sdk/std/net/ftp/list/mod.rs 97.05% <0.00%> (+0.08%) ⬆️
duckscript_sdk/src/sdk/std/net/ftp/nlst/mod.rs 97.05% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728bf25...12e387e. Read the comment docs.

Bundling (static linking) TLS library is a very bad idea from
a security perspective and linux distributions try to avoid it.
@sagiegurari
Copy link
Owner

@jirutka thanks a lot. i got a lot of requests to stop using the native openssl due to installation difficulties, but i see no harm in giving both options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants