Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with native-tls instead of rustls #672

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Allow building with native-tls instead of rustls #672

merged 1 commit into from
Jul 21, 2022

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Jul 21, 2022

Bundling (static linking) TLS library is a very bad idea from a security perspective and linux distributions try to avoid it.

See-Also: sagiegurari/duckscript#258

Bundling (static linking) TLS library is a very bad idea from
a security perspective and linux distributions try to avoid it.

See-Also: sagiegurari/duckscript#258
@sagiegurari sagiegurari changed the base branch from master to 0.35.14 July 21, 2022 12:01
@sagiegurari
Copy link
Owner

@jirutka thanks. updated the base branch.

@jirutka
Copy link
Contributor Author

jirutka commented Jul 21, 2022

Just a note: it’s really not a good idea to use the same naming schema for branches and tags (0.35.14).

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #672 (038f13a) into 0.35.14 (f9de0db) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           0.35.14     #672      +/-   ##
===========================================
- Coverage    93.52%   93.23%   -0.29%     
===========================================
  Files          112      112              
  Lines        21605    21597       -8     
===========================================
- Hits         20207    20137      -70     
- Misses        1398     1460      +62     
Impacted Files Coverage Δ
src/lib/scriptengine/shell_to_batch_test.rs 83.33% <0.00%> (-8.34%) ⬇️
src/lib/functions/getat_func_test.rs 86.48% <0.00%> (-8.11%) ⬇️
src/lib/functions/decode_func_test.rs 91.17% <0.00%> (-7.85%) ⬇️
src/lib/cli_commands/diff_steps.rs 87.17% <0.00%> (-7.70%) ⬇️
src/lib/functions/split_func_test.rs 85.00% <0.00%> (-5.00%) ⬇️
src/lib/config_test.rs 90.47% <0.00%> (-4.77%) ⬇️
src/lib/functions/mod_test.rs 94.73% <0.00%> (-3.01%) ⬇️
src/lib/environment/mod.rs 92.74% <0.00%> (-2.43%) ⬇️
src/lib/installer/cargo_plugin_installer_test.rs 92.61% <0.00%> (-2.28%) ⬇️
src/lib/scriptengine/generic_script_test.rs 88.88% <0.00%> (-1.86%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9de0db...038f13a. Read the comment docs.

@sagiegurari sagiegurari merged commit 5779553 into sagiegurari:0.35.14 Jul 21, 2022
@jirutka jirutka deleted the tls-native branch July 22, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants