Support networkx 3.1 #35584
Merged
Support networkx 3.1 #35584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint failure is unrelated: Is this a bug in 10.0.rc0 ? Or is this a case of workflow changing without making sure |
This was referenced Apr 29, 2023
mkoeppe
approved these changes
May 4, 2023
dcoudert
suggested changes
May 4, 2023
dcoudert
suggested changes
May 5, 2023
The functions `number_of_cliques()` and `cliques_containing_node()` are deprecated in networkx 3.1. This commit reimplements both functions based on method `cliques_maximal()`.
The previous implementation was taken from the ones that are deprecated in networkx 3.1. We replace it by a better implementation suggested by David Coudert.
|
Rebased to 10.0.rc2 without any change (removes spurious "fix the linter commits") |
|
Documentation preview for this PR is ready! 🎉 |
vbraun
pushed a commit
that referenced
this pull request
Jun 11, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> https://networkx.org/documentation/stable/release/index.html; still supports Python >= 3.8 (see #35404) - https://networkx.org/documentation/stable/release/release_3.1.html - https://networkx.org/documentation/stable/release/release_3.0.html python_igraph still supports Python >= 3.7. - https://igraph.org/2023/01/27/igraph-0.10.4-c.html - https://igraph.org/2022/12/30/igraph-0.10.3-c.html <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35584 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35671 Reported by: Matthias Köppe Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
The functions
number_of_cliques()andcliques_containing_node()are deprecated in networkx 3.1.This commit reimplements both functions based on method
cliques_maximal().This PR is critical to upgrade networkx to 3.1 in void linux.
📝 Checklist