Drop support for Python 3.8 #35404

tobiasdiez · 2023-03-31T08:07:13Z

📚 Description

In preparation for important package upgrades, we remove support for Python v3.8. (Almost) all occurrences of "Python 3.8" are removed from the codebase. There are still some comments left that essentially say that in newer versions things can be simplified, but I didn't touch those and leave them for follow-up PRs.

This will help with:

PRs that require Python 3.9 or above, such as sage.misc.prandom misses several functions added in Python 3 #34973 and Add typing to chart and calculus method #35188.
Upgrades of Python packages that have dropped support for Python 3.8 because they follow NEP 29 and have already released a new major version that drops support according to the NEP 29 schedule.
- NetworkX 3.2 (expected 2023-??; version 3.1 was released 2023-04, see Upgrade networkx to 3.1, igraph/python_igraph to 0.10.4 #35671)
- Update numpy to 1.26 #34816
- SciPy 1.11.x #35703
- See also Meta-ticket: Remove support for outdated distros #32074.

Test run: https://github.com/tobiasdiez/sage/actions/runs/4586981626

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

mkoeppe · 2023-03-31T15:36:06Z

Too early for 10.0.

dimpase · 2023-03-31T19:55:30Z

unless it's too late for @vbraun - then why not? what does it buy us, keeping an outdated Python version supported?

mkoeppe · 2023-03-31T20:10:03Z

You may recall that before I made it possible to use system Python for Sage, it was a frequent major complaint from users that Sage insists on building its own Python. And on major stability-oriented distributions (CentOS Stream, RHEL, Ubuntu focal LTS), Python 3.8 is the default or only supported Python version.

dimpase · 2023-03-31T20:21:57Z

Centos Stream has Python 3.9 available: https://www.server-world.info/en/note?os=CentOS_Stream_8&p=python&f=5

Ubuntu focal will be around for 2 more years - are you saying we must keep supporting Python 3.8 due to this?

RHEL has Python 3.9, too:
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_basic_system_settings/assembly_installing-and-using-python_configuring-basic-system-settings

So?

mkoeppe · 2023-03-31T20:29:58Z

are you saying we must keep supporting Python 3.8 due to this?

No, I am saying that is should be a factor in the decision when to drop Python 3.8. Right now, as I have explained in detail in https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/x3qOdPB5BQAJ, very little is gained by dropping it right now; so that needs to be weighed against what we lose – namely platform support.

tobiasdiez · 2023-04-03T06:42:42Z

The tests seem to pass and successfully reject system-installed python 3.8, e.g. https://github.com/tobiasdiez/sage/actions/runs/4586981626/jobs/8100195383. However, the second stage fails as there is a problem with the upload of the packages in my fork, but this is unrelated to this PR. So this is now indeed ready to go from my side.

dimpase · 2023-04-09T23:35:27Z

the rebase over the latest beta broke the build, and I cannot see why, sorry...

dimpase · 2023-04-09T23:39:52Z

I guess one needs

--- a/build/pkgs/tzlocal/dependencies
+++ b/build/pkgs/tzlocal/dependencies
@@ -1,4 +1,4 @@
-$(PYTHON) backports_zoneinfo pytz_deprecation_shim | $(PYTHON_TOOLCHAIN)
+$(PYTHON) pytz_deprecation_shim | $(PYTHON_TOOLCHAIN)
 
 ----------
 All lines of this file are ignored except the first.

tobiasdiez · 2023-04-10T11:20:30Z

Thanks Dima. This was actually not an issue with the merge, but I just overlooked it. Tests are green, so feel free to set it to positive review ;-)

dimpase

lgtm

mkoeppe · 2023-04-10T22:01:28Z

Dima, you are aware that I object to making this change for the 10.0

dimpase · 2023-04-10T22:50:09Z

So, what "info" is needed here?

tobiasdiez · 2023-04-12T02:44:10Z

The discussion here and at #35403 shows that neither side can convince the other side. Past experience shows that such cases are resolved by majority voting (e.g. #35105). For this PR here, there are two votes for (by @dimpase and @tobiasdiez) and one vote against (by @mkoeppe). Moreover, the PR has been open for over two weeks without other developers expressing their objection. Thus, setting it back to positive review.

mkoeppe · 2023-04-12T02:50:18Z

It definitely does not work this way.

mkoeppe · 2023-04-12T02:51:42Z

I have referred this to sage-abuse.

dimpase · 2023-04-12T10:36:29Z

What kind of work is needed here? It's mislabeling.
Or do you now require a 5-year Plan for any outdated feature removal, just like you apparently ask for in case of gcc spkg removal? Or in the latter case an approval of Politbureau is required too?

mkoeppe · 2023-08-21T17:01:13Z

Rebased

mkoeppe · 2023-08-21T17:27:20Z

I've made some small fixes during and after rebase.

If OK, this can be set to positive review, for merging in the 10.2 development series

… to prevent merge conflict with sagemath#35404

mkoeppe · 2023-08-22T18:01:35Z

Based on Dima's 👍, I've set it to positive review.

### 📚 Description In preparation for important package upgrades, we remove support for Python v3.8. (Almost) all occurrences of "Python 3.8" are removed from the codebase. There are still some comments left that essentially say that in newer versions things can be simplified, but I didn't touch those and leave them for follow-up PRs. This will help with: - PRs that require Python 3.9 or above, such as sagemath#34973 and sagemath#35188. - Upgrades of Python packages that have dropped support for Python 3.8 because they follow NEP 29 and have already released a new major version that drops support according to the NEP 29 schedule. - NetworkX 3.2 (expected 2023-??; version 3.1 was released 2023-04, see sagemath#35671) - sagemath#34816 - sagemath#35703 - See also sagemath#32074. Test run: https://github.com/tobiasdiez/sage/actions/runs/4586981626     ### 📝 Checklist  - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#35404 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Matthias Köppe

…-buster` and `fedora-29`    ### 📚 Description   Prerequisite of: - sagemath#34816 - sagemath#35703 - sagemath#35801 See also: - sagemath#32074 Instead of fully dropping `debian-buster` (LTS until 2024-06) in the CI, we replace it by `debian-buster-gcc_spkg` to verify that users on this platform have the recourse of installing a newer GCC. We also remove `linuxmint-19.3-gcc_8-python3.8` and change `fedora-30-python3.8` to `fedora-30` (which builds python from spkg), to prevent a merge conflict with sagemath#35404 We also add `debian-trixie` (= current testing).   ### 📝 Checklist  - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#35810 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik

This includes updates of `meson`, `meson_python`, `ninja_build`, `pybind11`, `pyproject_metadata`, `pythran`, `gast`.   Resolves sagemath#35703  ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on sagemath#35404 (merged here) - Depends on sagemath#35810 (merged here) - Depends on sagemath#35084 (merged here)  URL: sagemath#36112 Reported by: Matthias Köppe Reviewer(s): François Bissey

NumPy 1.26 provides Python 3.12 support and Cython 3 compatibility. 1.26.0 was released 2023-09-16. As NumPy has changed its build system from setuptools-pinned-to-an- ancient-version to meson_python, we get rid of our ancient version of `setuptools`. The SPKGs `setuptools` and `setuptools_wheel` now ship the same (current) version. - [x] Check portability run: https://github.com/mkoeppe/sage/actions/runs/5959239800 - [ ] Check SAGE_FAT_BINARY   Resolves sagemath#34816  ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - Depends on sagemath#36112 (for the `meson_python` upgrades, merged here) - Depends on sagemath#35404 (merged here as part of above) - Depends on sagemath#35810 (merged here as part of above) - Depends on sagemath#36110 (merged here) - Depends on sagemath#36263 (merged here) - Depends on sagemath#36238 (merged here) - Depends on sagemath#36255 (merged here)   URL: sagemath#36123 Reported by: Matthias Köppe Reviewer(s):

NumPy 1.26 provides Python 3.12 support and Cython 3 compatibility. 1.26.0 was released 2023-09-16. As NumPy has changed its build system from setuptools-pinned-to-an- ancient-version to meson_python, we get rid of our ancient version of `setuptools`. The SPKGs `setuptools` and `setuptools_wheel` now ship the same (current) version. - [x] Check portability run: https://github.com/mkoeppe/sage/actions/runs/5959239800 - [ ] Check SAGE_FAT_BINARY   Resolves #34816  ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - Depends on #36112 (for the `meson_python` upgrades, merged here) - Depends on #35404 (merged here as part of above) - Depends on #35810 (merged here as part of above) - Depends on #36110 (merged here) - Depends on #36263 (merged here) - Depends on #36238 (merged here) - Depends on #36255 (merged here)   URL: #36123 Reported by: Matthias Köppe Reviewer(s):

…kages       - sagemath#35203 added these packages as unconditional dependencies - prompted by a sporadic use of typing_extensions in the Sage library (see sagemath#34831) - motivated further by the demand to immediately drop support for Python 3.8 so that newer typing features can be used in the Sage library (sagemath#35404) - sagemath#36776 reduced the packages to conditional dependencies Here we improve the documentation in the section "Language standard" of the developer's guide so that it aligns with how the conditional dependencies are declared. Based on changes split out from sagemath#37399. ### 📝 Checklist  - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies    URL: sagemath#37654 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe

tobiasdiez added the s: needs review label Mar 31, 2023

tobiasdiez requested review from dimpase and mkoeppe March 31, 2023 08:07

dimpase force-pushed the python38 branch from aebd2ff to 49496ce Compare April 9, 2023 09:41

dimpase approved these changes Apr 10, 2023

View reviewed changes

dimpase added s: positive review and removed s: needs review labels Apr 10, 2023

mkoeppe added s: needs info and removed s: positive review labels Apr 10, 2023

This was referenced Apr 11, 2023

Adopt the “time window-based” policy for support of Python versions from Spec-0 #35403

Merged

Run PR build and test workflow for all supported python versions #35481

Closed

tobiasdiez added s: positive review and removed s: needs info labels Apr 12, 2023

mkoeppe added s: needs work and removed s: positive review labels Apr 12, 2023

mkoeppe removed this from the sage-10.1 milestone Aug 7, 2023

Matthias Koeppe and others added 3 commits August 21, 2023 09:59

Drop support for Python 3.8

ff5d9f6

remove removed backport from deps

e1c61cb

remove dependency on sagemath#35417

0060149

mkoeppe force-pushed the python38 branch from ade4d42 to 0060149 Compare August 21, 2023 17:00

mkoeppe added this to the sage-10.2 milestone Aug 21, 2023

mkoeppe added the p: critical / 2 label Aug 21, 2023

Matthias Koeppe and others added 2 commits August 21, 2023 10:22

README.md: Python 3.11 is ok

ce632b6

Remove tag fetching in docker workflow

11c2a87

mkoeppe approved these changes Aug 21, 2023

View reviewed changes

mkoeppe added a commit to mkoeppe/sage that referenced this pull request Aug 22, 2023

.github/workflows/docker.yml: Change fedora-30-python3.8 to fedora-30…

16cf964

… to prevent merge conflict with sagemath#35404

mkoeppe added s: positive review and removed s: needs review labels Aug 22, 2023

vbraun merged commit 055a3ea into sagemath:develop Aug 27, 2023

github-actions bot removed the s: positive review label Aug 27, 2023

tobiasdiez deleted the python38 branch August 27, 2023 21:43

mkoeppe added the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Dec 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for Python 3.8 #35404

Drop support for Python 3.8 #35404

tobiasdiez commented Mar 31, 2023 •

edited by mkoeppe

Loading

mkoeppe commented Mar 31, 2023

dimpase commented Mar 31, 2023

mkoeppe commented Mar 31, 2023

dimpase commented Mar 31, 2023

mkoeppe commented Mar 31, 2023

tobiasdiez commented Apr 3, 2023

dimpase commented Apr 9, 2023

dimpase commented Apr 9, 2023

tobiasdiez commented Apr 10, 2023

dimpase left a comment

mkoeppe commented Apr 10, 2023

dimpase commented Apr 10, 2023

tobiasdiez commented Apr 12, 2023

mkoeppe commented Apr 12, 2023

mkoeppe commented Apr 12, 2023 •

edited

Loading

dimpase commented Apr 12, 2023

mkoeppe commented Aug 21, 2023

mkoeppe commented Aug 21, 2023

mkoeppe commented Aug 22, 2023

Drop support for Python 3.8 #35404

Drop support for Python 3.8 #35404

Conversation

tobiasdiez commented Mar 31, 2023 • edited by mkoeppe Loading

📚 Description

📝 Checklist

⌛ Dependencies

mkoeppe commented Mar 31, 2023

dimpase commented Mar 31, 2023

mkoeppe commented Mar 31, 2023

dimpase commented Mar 31, 2023

mkoeppe commented Mar 31, 2023

tobiasdiez commented Apr 3, 2023

dimpase commented Apr 9, 2023

dimpase commented Apr 9, 2023

tobiasdiez commented Apr 10, 2023

dimpase left a comment

Choose a reason for hiding this comment

mkoeppe commented Apr 10, 2023

dimpase commented Apr 10, 2023

tobiasdiez commented Apr 12, 2023

mkoeppe commented Apr 12, 2023

mkoeppe commented Apr 12, 2023 • edited Loading

dimpase commented Apr 12, 2023

mkoeppe commented Aug 21, 2023

mkoeppe commented Aug 21, 2023

mkoeppe commented Aug 22, 2023

tobiasdiez commented Mar 31, 2023 •

edited by mkoeppe

Loading

mkoeppe commented Apr 12, 2023 •

edited

Loading