Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing KnotInfo wrappers for polynomial invariants #33969

Closed
soehms opened this issue Jun 10, 2022 · 18 comments
Closed

Implement missing KnotInfo wrappers for polynomial invariants #33969

soehms opened this issue Jun 10, 2022 · 18 comments
Labels
c: algebraic topology p: major / 3 t: enhancement
Milestone
sage-9.8

Comments

@soehms
Copy link
Member

soehms commented Jun 10, 2022

A couple of wrappers for link properties listed in the KnotInfo and LinkInfo databases have already been implemented in #30352. But since there are more than 120 of them there are still a lot missing. Here we add missing polynomial link invariants, explicitly the Conway and Khovanov polynomials.

Furthermore we let Sage point to the current version of database_knotinfo.

Depends on #33965
Depends on #33966

Component: algebraic topology

Author: Sebastian Oehms

Branch/Commit: b9b8743

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33969
@soehms soehms added this to the sage-9.7 milestone Jun 10, 2022
@soehms
Copy link
Member Author

soehms commented Jun 10, 2022

Branch: u/soehms/more_poly_invar_knotinfo_33969

@soehms
Copy link
Member Author

soehms commented Jun 10, 2022

Dependencies: #33965, #33966

@soehms
Copy link
Member Author

soehms commented Jun 10, 2022

Commit: b899290

@soehms
Copy link
Member Author

soehms commented Jun 10, 2022

Author: Sebastian Oehms

@soehms
Copy link
Member Author

soehms commented Jun 10, 2022

New commits:

99345e133966: initial
975f28a33965: initial
d6bf7a033965: small fix in docstring
00357b1Merge branch 'khovanov_poly_33965' into more_poly_invar_knotinfo
b89929033969: initial

@mkoeppe mkoeppe changed the title Implement missing KontInfo wrappers for polynomial invariants Implement missing KnotInfo wrappers for polynomial invariants Jun 14, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Changed commit from b899290 to ad7c107

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b991286Merge branch 'u/soehms/more_poly_invar_knotinfo_33969' of trac.sagemath.org:sage into more_poly_invar_knotinfo_33969
ad7c10733969: characteristic 2 only for knots and push to current db-version

@soehms
Copy link
Member Author

soehms commented Jul 4, 2022

comment:5

I just add a NotImplementedError for the Khovanov polynomial in characteristic 2 for multi-component links, since this is not supported by the database.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

ea8c7d4Merge branch 'u/soehms/more_poly_invar_knotinfo_33969' of trac.sagemath.org:sage into more_poly_invar_knotinfo_33969

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 30, 2022

Changed commit from ad7c107 to ea8c7d4

@soehms
Copy link
Member Author

soehms commented Sep 30, 2022

comment:8

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1. New commits:

ea8c7d4Merge branch 'u/soehms/more_poly_invar_knotinfo_33969' of trac.sagemath.org:sage into more_poly_invar_knotinfo_33969

Just rebasing to 9.8.beta1.

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 1, 2022

comment:9
+    def khovanov_polynomial(self, var1='q', var2='t', base_ring=ZZ, original=False):
+        r"""
+        Return the Khovanov polynomial according to the value of column
+        ``khovnov_polynomial`` for this knot or link as an instance of

typo: khovnov -> khovanov

Otherwise LGTM

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

b9b874333969: fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2022

Changed commit from ea8c7d4 to b9b8743

@soehms
Copy link
Member Author

soehms commented Oct 4, 2022

comment:11

Replying to Matthias Köppe:

+    def khovanov_polynomial(self, var1='q', var2='t', base_ring=ZZ, original=False):
+        r"""
+        Return the Khovanov polynomial according to the value of column
+        ``khovnov_polynomial`` for this knot or link as an instance of

typo: khovnov -> khovanov

Otherwise LGTM

Thank you for looking at the ticket!

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 4, 2022

Reviewer: Matthias Koeppe

@soehms
Copy link
Member Author

soehms commented Oct 5, 2022

comment:13

Replying to Matthias Köppe:
Many thanks!

@vbraun
Copy link
Member

vbraun commented Oct 16, 2022

Changed branch from u/soehms/more_poly_invar_knotinfo_33969 to b9b8743

@vbraun vbraun closed this as completed in 2356379 Oct 16, 2022
@vbraun vbraun mentioned this issue Oct 11, 2022
Closed
@soehms soehms mentioned this issue Feb 10, 2023
Merged
4 tasks
vbraun pushed a commit that referenced this issue Mar 13, 2023
gh-35063: Add notes about recent changes on KnotInfo
788415e 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

This is a follow up of #33969, which used the Khovanov polynomial
KnotInfo data in a new conversion method. Unfortunately, this data has
since been removed from the website (but not from the database).

This PR merely adds appropriate notes to the documentation of the
KnotInfo interface module.

Since the missing data may cause confusion, it would be great if the
notes will be included in release 9.8.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [ ] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35063
Reported by: Sebastian Oehms
Reviewer(s): Matthias Köppe, Sebastian Oehms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic topology p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @soehms