Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KnotInfo interface returns wrong braid_notation for the unknot #33966

Closed
soehms opened this issue Jun 9, 2022 · 8 comments
Closed

KnotInfo interface returns wrong braid_notation for the unknot #33966

soehms opened this issue Jun 9, 2022 · 8 comments
Labels
c: algebraic geometry p: major / 3 t: bug
Milestone
sage-9.7

Comments

@soehms
Copy link
Member

soehms commented Jun 9, 2022

The original database does not provide a value for the braid_notation of the unknot. Thus this value has been set individually in the interface, but unfortunately this value corresponds to a disjoint union of two unknots. This bug remained unnoticed because the construction of a link from a braid in Sage erases all additional unknots.

Component: algebraic geometry

Author: Sebastian Oehms

Branch/Commit: 99345e1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33966
@soehms soehms added this to the sage-9.7 milestone Jun 9, 2022
@soehms
Copy link
Member Author

soehms commented Jun 9, 2022

Branch: u/soehms/fix_unknot_braid_notation_knotinfo_33966

@soehms
Copy link
Member Author

soehms commented Jun 9, 2022

New commits:

99345e133966: initial

@soehms
Copy link
Member Author

soehms commented Jun 9, 2022

Commit: 99345e1

@soehms
Copy link
Member Author

soehms commented Jun 9, 2022

Author: Sebastian Oehms

@tscrim
Copy link
Collaborator

tscrim commented Jun 16, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 16, 2022

comment:3

LGTM.

@soehms
Copy link
Member Author

soehms commented Jun 17, 2022

comment:4

Thanks

@vbraun
Copy link
Member

vbraun commented Jun 19, 2022

Changed branch from u/soehms/fix_unknot_braid_notation_knotinfo_33966 to 99345e1

@vbraun vbraun closed this as completed in e79f6ff Jun 19, 2022
@soehms soehms mentioned this issue Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @soehms