Remove deprecated code from combinat/ #15466

nathanncohen · 2013-11-29T14:11:00Z

Removes deprecated code from #12930 #13821 #6136 (4 years old) #13072 #9265 together with #8429 #12469 #6519.

Nathann

Depends on #15467

CC: @sagetrac-sage-combinat

Component: combinatorics

Author: Nathann Cohen

Branch/Commit: d5086d0

Reviewer: Andrew Mathas, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15466

The text was updated successfully, but these errors were encountered:

nathanncohen · 2013-11-29T19:24:36Z

Dependencies: #15467

nathanncohen · 2013-11-29T19:24:36Z

Branch: u/ncohen/15466

sagetrac-git · 2013-11-29T19:24:58Z

Commit: a8bd310

sagetrac-git · 2013-11-29T19:24:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`[a8bd310](https://github.com/sagemath/sagetrac-mirror/commit/a8bd310)`	`trac #15466: Remove deprecated code from combinat/`
`[5993eac](https://github.com/sagemath/sagetrac-mirror/commit/5993eac)`	`trac #15467: Partitions should check its input "a bit" more carefully`

AndrewMathas · 2013-12-05T22:10:40Z

Changed branch from u/ncohen/15466 to u/andrew.mathas/ticket/15466

AndrewMathas · 2013-12-05T22:15:12Z

comment:4

Hi Nathann, thanks for starting this (or should that be thaaaaaaaaaaaanks!:).

I found a few more depreciated [sic] functions to remove in the words subdirectory and I moved a few import statements of deprecation so that they are now immediately above the function call. This will help ensure that there are no stray deprecation import statements left when the corresponding soon-to-be-depreciated code is removed. Finally, I killed off some documentation for some functions that are removed by this patch.

If you are happy with my changes let's make this a positive review. I've bumped the version number to 6 since we're using git.

[ps I have checked all of the doctsts in sage/combinat. I do get a doctext failure in root_system/coxeter_group.py but I get the same failure in master, so I think it has nothing to do with this ticket.]

New commits:

`[6639e75](https://github.com/sagemath/sagetrac-mirror/commit/6639e75)`	`A few more deprecations`

AndrewMathas · 2013-12-05T22:15:12Z

Reviewer: Andrew Mathas

AndrewMathas · 2013-12-05T22:15:12Z

Changed commit from a8bd310 to 6639e75

nathanncohen · 2013-12-05T22:48:31Z

comment:6

Yooooooooooo !!

Hi Nathann, thanks for starting this (or should that be thaaaaaaaaaaaanks!:).

Well I'm glad to receive your help with this ! :-D

I found a few more depreciated [sic] functions to remove in the words subdirectory and I moved a few import statements of deprecation so that they are now immediately above the function call. This will help ensure that there are no stray deprecation import statements left when the corresponding soon-to-be-depreciated code is removed.

GoodGoodGood !

Finally, I killed off some documentation for some functions that are removed by this patch.

Argggg ! Nice job spotting that ;-)

By the way : these days I use the --warn-links flag when building the doc. It tells you whenever some links are made toward non-existent functions. I guess it will be useful to spot things like that in the future, when this --warn-links will be a default, though right now there are too many broken lins in Sage to make it the default :-)

If you are happy with my changes let's make this a positive review. I've bumped the version number to 6 since we're using git.

The tests passed while I was reading the patch. Good to go, thanks :-)

[ps I have checked all of the doctsts in sage/combinat. I do get a doctext failure in root_system/coxeter_group.py but I get the same failure in master, so I think it has nothing to do with this ticket.]

Hmmmmm.. I don't get this error. Though at some point Volker told me that I should run "make" again in Sage's directory to update the spkg which may have changed since. Do give it a try when you don't need to use Sage for a while (it will recompile a lot of things). I used to have a couple of broken doctests, and it solved it !

Thank you again, and positive review to this patch ! ;-)

Nathann

vbraun · 2013-12-17T22:08:11Z

comment:9

sage -t src/sage/misc/cachefunc.pyx
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 534, in sage.misc.cachefunc.CachedFunction.__init__
Failed example:
    g.cache
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 722, in sage.misc.cachefunc.CachedFunction.__call__
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 761, in sage.misc.cachefunc.CachedFunction.get_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 802, in sage.misc.cachefunc.CachedFunction.set_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 805, in sage.misc.cachefunc.CachedFunction.set_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 17}
Got:
    {((5, 'default'), ()): 17}
**********************************************************************
File "src/sage/misc/cachefunc.pyx", line 867, in sage.misc.cachefunc.CachedFunction.clear_cache
Failed example:
    g.get_cache()
Expected:
    {((5, None, 'default'), ()): 7}
Got:
    {((5, 'default'), ()): 7}
**********************************************************************

tscrim · 2014-01-21T19:58:34Z

comment:10

Fixed the failing doctest.

New commits:

`34aa97a`	`Merge branch 'u/andrew.mathas/ticket/15466' of trac.sagemath.org:sage into u/tscrim/ticket/15466`
`cd43d7b`	`Fixed failing doctests for #15466.`

tscrim · 2014-01-21T19:58:34Z

Changed branch from u/andrew.mathas/ticket/15466 to u/tscrim/ticket/15466

tscrim · 2014-01-21T19:58:34Z

Changed commit from 6639e75 to cd43d7b

AndrewMathas · 2014-01-22T07:19:45Z

comment:11

I didn't understand why this patch should affect cachefunc.pyx but the doc-tests causing the problems all call number_of_partitions. Part of this patch removes depreciated code in partition.py and, in particular, it changes the calling syntax by removing a depreciated argument of k=None. This both explains the errors above and says that the correct fix is simply to change the output of the doct-tests as the patch does. Hence, positive review.

Andrew

vbraun · 2014-02-21T23:05:32Z

comment:13

conflict, please merge in latest beta

sagetrac-git · 2014-02-22T06:22:22Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`25488e8`	`Merge branch 'u/tscrim/ticket/15466' of trac.sagemath.org:sage into u/tscrim/ticket/15466`

sagetrac-git · 2014-02-22T06:22:22Z

Changed commit from cd43d7b to 25488e8

tscrim · 2014-02-22T06:23:18Z

comment:15

Done.

tscrim · 2014-02-22T06:23:18Z

Changed reviewer from Andrew Mathas to Andrew Mathas, Travis Scrimshaw

vbraun · 2014-02-22T07:15:31Z

comment:16

Documentation doesn't build

build/pipestatus "./sage --docbuild --no-pdf-links all html -j  2>&1" "tee -a logs/dochtml.log"
Setting permissions of DOT_SAGE directory so only you can read and write it.
Traceback (most recent call last):
  File "/Users/buildslave-sage/slave/sage_git/build/src/doc/common/builder.py", line 1465, in <module>
    import sage.all
  File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/all.py", line 133, in <module>
    from sage.combinat.all   import *
  File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/combinat/all.py", line 1, in <module>
    from combinat import bell_number, catalan_number, euler_number, fibonacci, \
ImportError: cannot import name combinations

tscrim · 2014-02-22T17:50:20Z

comment:17

I'm unable to reproduce this. I rebuilt, ran sync-build, rebuilt, nuked my docbuild, and rebuilt the entire doc.

vbraun · 2014-02-22T21:28:42Z

comment:18

Might be due to #9505, please wait until 6.2.beta3 is out and then merge that in.

vbraun · 2014-03-04T17:02:04Z

comment:19

6.2.beta3 is out ;-)

nathanncohen · 2014-03-05T10:00:10Z

comment:20

Done !

Nathann

New commits:

`b4f424b`	`trac #15466: Rebase on 6.2.beta3`
`d5086d0`	`trac #15466: remove dead import`

nathanncohen · 2014-03-05T10:00:10Z

Changed commit from 25488e8 to d5086d0

nathanncohen · 2014-03-05T10:00:10Z

Changed branch from u/tscrim/ticket/15466 to u/ncohen/15466

tscrim · 2014-03-05T16:14:33Z

comment:21

Hmmm...strange... I didn't see those imports when looking at the branch before. shrugs

PS - Thanks Nathann.

nathanncohen · 2014-03-05T16:29:39Z

comment:22

Yeah, I find it strange too.... And I don't see why they could have been added from another patch in the meantime O_o

Nathann

vbraun · 2014-03-06T15:06:58Z

Changed branch from u/ncohen/15466 to d5086d0

* develop: (100 commits) Updated Sage version to 6.2.beta4 added documentation, patchlevel bump trac sagemath#15894 modif of two warnings delete cruft from the guava package trac sagemath#15893 review patch trac sagemath#15894 another backward change trac sagemath#15894 changin back the category names trac #15xxx proper names should start by a capital letter Fix changelog entry for ell_wp trac sagemath#15893: graphs.petersen_family Fixes to code from sagemath#9505. Fix the banner displayed by sage -h trac sagemath#15466: remove dead import trac sagemath#15795 line wrap trac sagemath#15795 redone with ( ::) Fraction to power series: doctests Fraction to power series conversion when the fraction coerces into the base ring 15698: Allow construction of power series from fractions Create *unevaluated* integrals when converting sage integrals to sympy Use evaluate=False in SympyConverter too ...

nathanncohen mannequin added this to the sage-5.13 milestone Nov 29, 2013

nathanncohen mannequin added c: combinatorics labels Nov 29, 2013

This comment has been minimized.

Sign in to view

nathanncohen mannequin changed the title ~~Remove deprecated code from combinat.py~~ Remove deprecated code from combinat/ Nov 29, 2013

nathanncohen mannequin added the s: needs review label Nov 29, 2013

AndrewMathas modified the milestones: sage-5.13, sage-6.0 Dec 5, 2013

This comment has been minimized.

Sign in to view

nathanncohen mannequin added s: positive review and removed s: needs review labels Dec 5, 2013

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.0, sage-6.1 Dec 17, 2013

vbraun removed the s: positive review label Dec 17, 2013

vbraun closed this as completed Dec 17, 2013

vbraun reopened this Dec 17, 2013

tscrim added the s: needs review label Jan 21, 2014

AndrewMathas added s: positive review and removed s: needs review labels Jan 22, 2014

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014

sagetrac-git mannequin added s: needs review and removed s: positive review labels Feb 22, 2014

tscrim added s: positive review and removed s: needs review labels Feb 22, 2014

vbraun removed the s: positive review label Mar 6, 2014

vbraun closed this as completed in 4c30132 Mar 6, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated code from combinat/ #15466

Remove deprecated code from combinat/ #15466

nathanncohen mannequin commented Nov 29, 2013

This comment has been minimized.

nathanncohen mannequin commented Nov 29, 2013

nathanncohen mannequin commented Nov 29, 2013

sagetrac-git mannequin commented Nov 29, 2013

sagetrac-git mannequin commented Nov 29, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

This comment has been minimized.

nathanncohen mannequin commented Dec 5, 2013

vbraun commented Dec 17, 2013

tscrim commented Jan 21, 2014

tscrim commented Jan 21, 2014

tscrim commented Jan 21, 2014

AndrewMathas commented Jan 22, 2014

vbraun commented Feb 21, 2014

sagetrac-git mannequin commented Feb 22, 2014

sagetrac-git mannequin commented Feb 22, 2014

tscrim commented Feb 22, 2014

tscrim commented Feb 22, 2014

vbraun commented Feb 22, 2014

tscrim commented Feb 22, 2014

vbraun commented Feb 22, 2014

vbraun commented Mar 4, 2014

nathanncohen mannequin commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

tscrim commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

vbraun commented Mar 6, 2014

Remove deprecated code from combinat/ #15466

Remove deprecated code from combinat/ #15466

Comments

nathanncohen mannequin commented Nov 29, 2013

This comment has been minimized.

nathanncohen mannequin commented Nov 29, 2013

nathanncohen mannequin commented Nov 29, 2013

sagetrac-git mannequin commented Nov 29, 2013

sagetrac-git mannequin commented Nov 29, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

AndrewMathas commented Dec 5, 2013

This comment has been minimized.

nathanncohen mannequin commented Dec 5, 2013

vbraun commented Dec 17, 2013

tscrim commented Jan 21, 2014

tscrim commented Jan 21, 2014

tscrim commented Jan 21, 2014

AndrewMathas commented Jan 22, 2014

vbraun commented Feb 21, 2014

sagetrac-git mannequin commented Feb 22, 2014

sagetrac-git mannequin commented Feb 22, 2014

tscrim commented Feb 22, 2014

tscrim commented Feb 22, 2014

vbraun commented Feb 22, 2014

tscrim commented Feb 22, 2014

vbraun commented Feb 22, 2014

vbraun commented Mar 4, 2014

nathanncohen mannequin commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

tscrim commented Mar 5, 2014

nathanncohen mannequin commented Mar 5, 2014

vbraun commented Mar 6, 2014