Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeError raised by standard_factorization of a finite word #12469

Closed
sagetrac-htremblay mannequin opened this issue Feb 7, 2012 · 12 comments
Closed

RuntimeError raised by standard_factorization of a finite word #12469

sagetrac-htremblay mannequin opened this issue Feb 7, 2012 · 12 comments
Assignees
@sagetrac-htremblay
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-5.1

Comments

@sagetrac-htremblay
Copy link
Mannequin

sagetrac-htremblay mannequin commented Feb 7, 2012 

sage: w=Word('babba')
sage: w.standard_factorization_of_lyndon_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words

sage: w=Word('a')
sage: w.standard_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words

Apply

  1. attachment: trac_12469.patch
  2. attachment: trac_12469_correction.patch
  3. attachment: trac_12469_reviewer.patch

CC: @seblabbe

Component: combinatorics

Author: Hugo Tremblay

Reviewer: André Apitzsch

Merged: sage-5.1.beta0

Issue created by migration from https://trac.sagemath.org/ticket/12469
@sagetrac-htremblay sagetrac-htremblay mannequin added this to the sage-5.0 milestone Feb 7, 2012
@sagetrac-htremblay sagetrac-htremblay mannequin self-assigned this Feb 7, 2012
@sagetrac-htremblay
Copy link
Mannequin Author

sagetrac-htremblay mannequin commented Feb 13, 2012

Attachment: trac_12469.patch.gz

tested on sage-4.8

@sagetrac-htremblay
Copy link
Mannequin Author

sagetrac-htremblay mannequin commented Feb 13, 2012

Author: Hugo Tremblay

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 13, 2012

comment:2

Seems to be failing a doctest on 5.0.beta7 according to the patchbot. This looks completely trivial, but please check.

@loefflerd loefflerd mannequin added s: needs work and removed s: needs review labels Mar 13, 2012
@a-andre
Copy link

a-andre commented Apr 29, 2012

Attachment: trac_12469_reviewer.patch.gz

@a-andre

This comment has been minimized.

Sign in to view
@a-andre
Copy link

a-andre commented Apr 29, 2012

Reviewer: André Apitzsch

@a-andre
Copy link

a-andre commented Apr 29, 2012

comment:4

If you are okay with my patch you can change the status to positive review.

@sagetrac-htremblay
Copy link
Mannequin Author

sagetrac-htremblay mannequin commented May 2, 2012

comment:5

Tested on Sage Version 4.8.

@jdemeyer jdemeyer modified the milestones: sage-5.0, sage-5.1 May 2, 2012
@jdemeyer
Copy link

jdemeyer commented May 4, 2012

comment:7

Can you give the second patch a good commit message?

@jdemeyer
Copy link

jdemeyer commented May 9, 2012

comment:8

ping

@sagetrac-htremblay
Copy link
Mannequin Author

sagetrac-htremblay mannequin commented May 9, 2012

Attachment: trac_12469_correction.patch.gz

Applies on the previous patch

@jdemeyer
Copy link

Merged: sage-5.1.beta0

@nathanncohen nathanncohen mannequin mentioned this issue Mar 6, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-htremblay sagetrac-htremblay

Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-5.1
Development

No branches or pull requests
2 participants
@jdemeyer @a-andre