-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stembridge local characterization for crystal bases #11183
Comments
Attachment: trac_11183-crystals_local_characterization-td.patch.gz exported patch file |
Reviewer: Anne Schilling |
comment:2
This patch implements the local axioms for highest weight crystals of simply-laced types. This is a very useful test to check that a given crystal is actually consistent (for simply-laced types these tests are necessary and sufficient, for nonsimply-laced types only necessary). I tested this patch mathematically on several crystals. sage -t on all relevant crystal code passes. If the buildbot gives green light for all tests, this is a positive review! |
comment:3
Currently, the tests in /sage/categories/examples/crystals.py do not pass and need to be updated. In addition, it would be good to provide an implementation of a simple "crystal" that does not pass the Stembridge tests in this file. So I set this to "needs work". Anne |
comment:4
I reviewed the final version of the patch and it looks good now! The tests of all modified files pass. If the buildbot gives a green light, this has a positive review! Anne Apply: trac_11183-crystals_local_characterization-final.patch |
Changed author from tom denton to Tom Denton |
comment:6
Note: I had to (trivially) rebase #10998 on top of this patch. Please check that the queue apply next time :-) |
comment:8
The first line of the patch file is
This should not be there. Probably you made some script which writes such a line, I think it is best to undo that. |
comment:9
Also, there are some problems building the documentation:
|
comment:10
Replying to @jdemeyer:
This spurious line was removed in the revised patch. Best wishes, Anne |
comment:11
Replying to @jdemeyer:
The two warnings should be fixed in the revised patch. Best wishes, Anne |
Merged: sage-4.7.2.alpha1 |
Implementation of the Stembridge local axioms for crystal bases. Some functions added for checking these axioms, and _test_stembridge_local_axioms() was added to the test suite for highest weight crystals.
CC: @sagetrac-sage-combinat @anneschilling
Component: combinatorics
Keywords: crystals
Author: Tom Denton
Reviewer: Anne Schilling
Merged: sage-4.7.2.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/11183
The text was updated successfully, but these errors were encountered: