Implement an example of a graded algebra with basis, and improve the later #9280

jhpalmieri · 2010-06-20T03:39:29Z

The summary says it all. See also the patch on the Sage-Combinat patch server:

http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_9280-graded-algebras-example.patch

Thanks to Jason Bandlow and Franco Saliola who participated to the improvement of the example. It now depends on #10193.

Depends on #10193
Depends on #12453

Component: categories

Keywords: graded algebra

Author: John Palmieri, Nicolas M. Thiéry

Branch/Commit: public/categories/graded_examples-9280 @ fb05e6c

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/9280

The text was updated successfully, but these errors were encountered:

nthiery · 2010-07-21T05:10:48Z

comment:2

Attachment: trac_9280-graded-algebras-example.patch.gz

Hi John,

For the record: we went through your patches with Franco and Jason, and discussed quite a bit around it. We will post here shortly an updated patch with some little suggestions.

jhpalmieri · 2010-10-01T22:17:48Z

comment:3

Replying to @nthiery:

Hi John,

For the record: we went through your patches with Franco and Jason, and discussed quite a bit around it. We will post here shortly an updated patch with some little suggestions.

Is it "shortly" yet? :)

nthiery · 2010-10-31T11:01:39Z

Changed author from John Palmieri to John Palmieri, Nicolas M. Thiéry

jhpalmieri · 2010-11-08T23:27:34Z

comment:6

In the sage-combinat patch, there are a few typos and some other issues:

in sage/categories/graded_algebras_with_basis.py, the docstring for "degree" says "The degree of this element in the graded polynomial algebra." Delete "polynomial".
in sage/categories/examples/graded_algebras_with_basis.py, the docstring for "one_basis" contains '(0,...,0`), and I think this should be changed to ``(0,...,0)``.
in sage/categories/examples/graded_algebras_with_basis.py, the docstring for the main class is now outdated: it still refers to "basis_function" and "_basis_fcn", which don't exist any more, and also to "homogeneous_component", which is now part of the default implementation, not something specific to this example.

I'm attaching a referee patch which fixes these.

There are also some doctests for "basis" in sage/categories/graded_algebras_with_basis.py which are marked as "todo: not implemented". Do we need to wait for these to be fixed, or should we consider this ready for review? It may not be ideal, but we could also change

sage: A.basis(6) # todo: not implemented (output)
Family (y^{2}, x^{3}

to

sage: A.basis(6) # todo: not implemented (output)
Family (y^{2}, x^{3}
sage: list(A.basis(6))
[y^{2}, x^{3}]

By the way, all tests pass with this patch and with the one from #10193. So perhaps we could also delete the commented-out part at the beginning of the example, where it says

# TODO: double check that we can now discard this function

jhpalmieri · 2010-11-08T23:28:27Z

Attachment: trac_9280-ref.patch.gz

apply on top of sage-combinat patch

fchapoton · 2011-06-11T12:33:13Z

Dependencies: #10193

saliola · 2012-07-13T14:53:29Z

comment:8

There are a couple of patches on the sage-combinat queue experimenting with moving some of the generic methods into the category GradedAlgebraWithBasis:

trac_9280-graded-algebras-example-review-fs.patch
trac_9280-graded-algebras-example.patch

videlec · 2013-02-13T22:46:26Z

comment:9

Sorry for the long delay for the ticket but #10193 is now ready !!

fchapoton · 2013-08-21T13:11:07Z

Changed keywords from none to graded algebra

fchapoton · 2013-08-23T08:29:28Z

comment:11

Franco, Nicolas, what can we do with this ticket ? Should we use the patch from the combinat queue or the patch here ?

fchapoton · 2013-08-30T16:01:47Z

Attachment: trac_9280-graded-algebras-example-fs.patch.gz

fchapoton · 2013-08-30T16:02:31Z

comment:12

let me take the patch of sage-combinat as a starting point.

for the bot: apply only trac_9280-graded-algebras-example-fs.patch

jhpalmieri · 2013-08-30T17:57:08Z

comment:13

I don't know why I'm listed as an author in the file "sage/categories/examples/graded_modules_with_basis.py"; I don't think I had anything to do with that.

fchapoton · 2013-08-30T18:37:31Z

comment:14

The part of this patch concerning modules has been separated into ticket #11688 : the ticket #11688 should go first, then this one will need to be rebased on it.

I upload here the "algebra only patch" that will be the new starting point.

fchapoton · 2013-08-30T18:38:13Z

Attachment: trac_9280_nomodule.patch.gz

fchapoton · 2013-09-15T16:38:12Z

comment:15

this needs to be rebased

tscrim · 2013-12-20T03:15:41Z

comment:16

Since the graded algebras with basis example is using (weighted) integer vectors, we need #12453. I'd like to attach the branch "public/categories/graded_examples-9280", but trac is giving me an error when I try...

tscrim · 2013-12-20T03:15:41Z

Changed dependencies from #10193 to #10193 #12453

tscrim · 2013-12-21T15:41:23Z

Branch: public/categories/graded_examples-9280

tscrim · 2013-12-21T15:41:23Z

Commit: 32dc807

tscrim · 2013-12-21T15:41:23Z

New commits:

`32dc807`	`Fixed failing doctests.`
`c467bdb`	`Merge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280`
`ef2ddce`	`#12453: Refactored IntegerVectors to use ClonableIntArray.`
`c82765f`	`Initial review changes.`
`e2c3ae8`	`Merge branch 'public/categories/examples-9280' into public/categoires/graded_example-9280`
`6fffda7`	`Merge branch 'master' into public/categories/examples-9280`
`3491e78`	`imported patch trac_9280_nomodule.patch`

tscrim · 2013-12-21T15:41:23Z

Reviewer: Frederic Chapoton, Travis Scrimshaw

fchapoton · 2013-12-21T19:59:50Z

Changed reviewer from Frederic Chapoton, Travis Scrimshaw to Frédéric Chapoton, Travis Scrimshaw

sagetrac-git · 2014-01-25T19:01:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`161cedb`	`Merge branch 'develop' into public/categories/graded_examples-9280`
`badae2a`	`Merge branch 'develop' into public/categories/graded_examples-9280`
`eb793cc`	`Merge branch 'develop' into public/refactor_integer_vectors-12453`
`b9f278e`	`Merge branch 'develop' into public/refactor_integer_vectors-12453`
`2346b02`	`Merge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280`

sagetrac-git · 2014-01-25T19:01:12Z

Changed commit from 32dc807 to 2346b02

sagetrac-git · 2014-02-08T17:58:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`12bac19`	`Merge branch 'develop' into public/refactor_integer_vectors-12453`
`fb05e6c`	`Merge branch 'public/refactor_integer_vectors-12453' into public/categories/graded_examples-9280`

sagetrac-git · 2014-02-08T17:58:19Z

Changed commit from 2346b02 to fb05e6c

fchapoton · 2014-08-10T11:36:17Z

comment:21

needs rebase

jhpalmieri · 2016-08-25T16:48:34Z

comment:23

Yet another instance of someone asking a question related to this. Six (!) years ago, when I opened this ticket, I thought it would be good to have an example in the Sage library and in the documentation, and I really can't understand why this hasn't been taken care of yet. I am not interested in working on it myself any more, but I find it incredibly frustrating that this ticket has languished for so long.

http://ask.sagemath.org/question/34577/can-sage-compute-a-basis-for-the-graded-parts-of-a-graded-ring/

tscrim · 2016-08-25T19:27:51Z

comment:24

It is because of the dependency on integer vectors, which led to #12453. We can either give a new example based on another object or we review #12453 (which I just did a [non-trivial] rebase to the latest beta).

jhpalmieri added c: categories labels Jun 20, 2010

jhpalmieri assigned nthiery Jun 20, 2010

jhpalmieri added the s: needs review label Jun 20, 2010

This comment has been minimized.

Sign in to view

nthiery changed the title ~~implement an example of a graded algebra with basis~~ Implement an example of a graded algebra with basis, and improve the later Oct 31, 2010

This comment has been minimized.

Sign in to view

fchapoton added s: needs work and removed s: needs review labels Sep 15, 2013

tscrim added s: needs review and removed s: needs work labels Dec 20, 2013

fchapoton added s: needs work and removed s: needs review labels Aug 10, 2014

fchapoton added this to the sage-6.8 milestone Jul 17, 2015

tscrim modified the milestones: sage-6.8, sage-7.4 Aug 25, 2016

mkoeppe removed this from the sage-7.4 milestone Dec 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement an example of a graded algebra with basis, and improve the later #9280

Implement an example of a graded algebra with basis, and improve the later #9280

jhpalmieri commented Jun 20, 2010

nthiery commented Jul 21, 2010

jhpalmieri commented Oct 1, 2010

nthiery commented Oct 31, 2010

This comment has been minimized.

This comment has been minimized.

jhpalmieri commented Nov 8, 2010

jhpalmieri commented Nov 8, 2010

fchapoton commented Jun 11, 2011

saliola commented Jul 13, 2012

videlec commented Feb 13, 2013

fchapoton commented Aug 21, 2013

fchapoton commented Aug 23, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

jhpalmieri commented Aug 30, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Sep 15, 2013

tscrim commented Dec 20, 2013

tscrim commented Dec 20, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

fchapoton commented Dec 21, 2013

sagetrac-git mannequin commented Jan 25, 2014

sagetrac-git mannequin commented Jan 25, 2014

sagetrac-git mannequin commented Feb 8, 2014

sagetrac-git mannequin commented Feb 8, 2014

fchapoton commented Aug 10, 2014

jhpalmieri commented Aug 25, 2016

tscrim commented Aug 25, 2016

Implement an example of a graded algebra with basis, and improve the later #9280

Implement an example of a graded algebra with basis, and improve the later #9280

Comments

jhpalmieri commented Jun 20, 2010

nthiery commented Jul 21, 2010

jhpalmieri commented Oct 1, 2010

nthiery commented Oct 31, 2010

This comment has been minimized.

This comment has been minimized.

jhpalmieri commented Nov 8, 2010

jhpalmieri commented Nov 8, 2010

fchapoton commented Jun 11, 2011

saliola commented Jul 13, 2012

videlec commented Feb 13, 2013

fchapoton commented Aug 21, 2013

fchapoton commented Aug 23, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

jhpalmieri commented Aug 30, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

fchapoton commented Sep 15, 2013

tscrim commented Dec 20, 2013

tscrim commented Dec 20, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

tscrim commented Dec 21, 2013

fchapoton commented Dec 21, 2013

sagetrac-git mannequin commented Jan 25, 2014

sagetrac-git mannequin commented Jan 25, 2014

sagetrac-git mannequin commented Feb 8, 2014

sagetrac-git mannequin commented Feb 8, 2014

fchapoton commented Aug 10, 2014

jhpalmieri commented Aug 25, 2016

tscrim commented Aug 25, 2016