-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of energy function for crystals #11546
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Ready for review! |
This comment has been minimized.
This comment has been minimized.
comment:4
While the new returns:
It looks like the new 'i' is being added to opposite ends of the list in these two cases; is this consistent one way or the other across the code-base? This reminds me of a functionality extension I had thought would be nice at one point, namely being able to feed a list to the 'e' and 'f' functions instead of just a single letter. It would both extend the functionality a bit and establish a convention for which way this 'list' should be applied! |
comment:5
Hi Tom, Thank you for looking at the patch! Replying to @sdenton4:
classical_crystal is an attribute, not a method, so the correct way of using it is
The notion of level really only exists for perfect crystals. However, the method affine_grading also works in the non-perfect setting. Note that in the assert there is no ceiling for the quotient!
Doing it this way gives the same output as before! I did not change any of the tests and they still pass.
This already exists and is used as follows:
|
This comment has been minimized.
This comment has been minimized.
comment:7
Hi Tom, Methods level and is_perfect have been added to the Kirillov-Reshetikhin crystal code. Thanks, Anne |
Reviewer: Tom Denton |
comment:8
great! Best, |
comment:9
Replying to @sdenton4:
Hi Tom, Thanks for the careful review! Anne |
Dependencies: #11183 |
This comment has been minimized.
This comment has been minimized.
Work Issues: documentation |
comment:11
There are multiple problems with the documentation:
|
comment:12
Hi! The problems regarding the references should be fixed in the revised patch. Best regards, Anne |
comment:14
Unfortunately, for me the problem is still not fixed:
|
Attachment: trac_11546-crystals_energy-as.patch.gz |
comment:15
Replying to @jdemeyer:
Unfortunately, I cannot reproduce the problem, but I hope it is fixed with the Best wishes, Anne |
Merged: sage-4.7.2.alpha1 |
Changed work issues from documentation to none |
comment:16
It works now, thanks! |
This patch implements the energy function and affine grading for affine crystals and adds an
entry in the corresponding thematic tutorial. It also adds functions to obtain the level and test perfectness
for Kirillov-Reshetikhin crystals.
In addition, it removes the condition that for the Lusztig involution the element is supposed
to live in a crystal with a single highest weight element, and modifies the methods
to_highest_weight and to_lowest_weight in crystal.py to make them more robust.
The update to the thematic tutorial can be built using
is available here:
http://www.math.ucdavis.edu/~anne/sage/lie/affine_crystals.html
Apply: attachment: trac_11546-crystals_energy-as.patch
Depends on #11183
CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: energy, crystals
Author: Anne Schilling
Reviewer: Tom Denton
Merged: sage-4.7.2.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/11546
The text was updated successfully, but these errors were encountered: