-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further progress on right orthogonal calculus #112
Further progress on right orthogonal calculus #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've had enough of making all these formatting corrections, and I'm sure you are done with formatting code and seeing my comments as well. I'll write an autoformatting script over the weekend so we can move on to more productive things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me say, although my code comments may not suggest it, I think this PR looks excellent overall.
Co-authored-by: Fredrik Bakke <[email protected]>
@fredrik-bakke I have dismissed (marked as resolved) some of your suggestions which should be addressed in the PR #111 on which this one builds. |
In case you missed it, there's a single comment left to resolve. After that, this PR seems ready to merge to me. |
Co-authored-by: Fredrik Bakke <[email protected]>
I had a chat with Nikolai before the weekend. He and his student will try to set up basic autoformatting functionality built into the Rzk ecosystem instead, so the autoformatting will have to wait a little. |
Right orthogonal maps are closed under composition and right cancel.
Right orthogonal maps are closed under relative products (=pullback).
Point 2 was surprisingly tricky. Maybe there was an easier way to do this. I did this by setting up a theory of relative extension types and generalized relative extension types which might be of independent interest.
The two main steps are:
A map is right orthogonal if and only if all its relative extension types are contractible if and only if all its generalized relative extension types are contractible.
Each relative extension type of the pulled back map appears as retract of a generalized relative extension type of the original map.
Notes: