Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transcript for episode 008 #57

Merged
merged 3 commits into from
Jun 20, 2020

Conversation

ericseppanen
Copy link
Contributor

There are 5 places where I couldn't work out what was said (marked with "unintelligible" and a timestamp).

I don't think it hurts the readability much.

@ericseppanen
Copy link
Contributor Author

The CI file size error is unrelated to this PR. I opened issue #58 to discuss that.

@ericseppanen
Copy link
Contributor Author

Oops, just noticed a markdown rendering error. Needs an extra patch.

@ericseppanen
Copy link
Contributor Author

This is a little unlucky. Word wrap of "I can figure out that this is 4. It is very simple." happened to add a line-break just before the "4." which caused markdown to generate a numbered list.

I like adding word wrap because it makes git diff a lot easier to read, but this is the first time it's caused me trouble. This makes me wonder if word wrap is such a good idea after all?

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2020

The word wrapping is awkward, and a general Markdown problem, but I'd just manually work around it by wrapping that particular line differently manually.

If we add a line break just before "4." then markdown generates a
numbered list. That's not helpful.
@ericseppanen
Copy link
Contributor Author

I rebased against master and the CI issue cleared up (for now.)

I also added the suggestions you made.

@jonhoo jonhoo merged commit aa2eb4e into rustacean-station:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants