Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on unrelated PR fails with an error on episode 15 #58

Open
ericseppanen opened this issue Jun 19, 2020 · 10 comments
Open

CI on unrelated PR fails with an error on episode 15 #58

ericseppanen opened this issue Jun 19, 2020 · 10 comments

Comments

@ericseppanen
Copy link
Contributor

When queuing up a transcript for episode 008 (#57), I get a CI error:

015-twir-339.md: 7116560b (reported) != 5267717b (actual)

This seems a little weird-- why don't I see this error on PR #55?

@nellshamrell any ideas? It seems to behave as though commit 92154b7 is backwards or not applied, or we're serving the wrong mp3 file?

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2020

This is so weird. It looks like the file size of that file keeps fluctuating? As far as I can tell, the correct size is 5267717. But that was rejected in #55. I have no idea what's going on with that... Maybe the CI script is wrong?

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2020

I pushed a fix for that now. Let's see what CI does.

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 19, 2020

Err, that seems to have passed... So strange..

@ericseppanen
Copy link
Contributor Author

This one seems wrong as well, but isn't throwing errors?

018-twir-343.md:length: "124"

This is roughly what you get if there's a 404 trying to fetch the mp3 file. Note that curl doesn't return an error when this happens. (Maybe curl -f would do better?)

@ericseppanen
Copy link
Contributor Author

Ah, the episode 18 glitch is caused by there being a space after the URL. Curl is trying to fetch that and getting a 404.

I'll play with the script a little bit to see if I can get it to fail in a less obscure way on 404 errors.

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 20, 2020

Ah, yes, that would certainly do it! Thanks.

@jonhoo jonhoo closed this as completed in 78b9555 Jun 20, 2020
@ericseppanen
Copy link
Contributor Author

Unfortunately, I don't think commit 78b9555 explains why the file size of episode 15 would have been fluctuating. As far as I can tell episode 18 had a completely separate glitch.

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 20, 2020

Yeah, that's true.. I guess I'll re-open in case it shows up again.

@jonhoo jonhoo reopened this Jun 20, 2020
@ericseppanen
Copy link
Contributor Author

I wonder if there's some kind of intrusive caching layer within github, so if your CI scripts run a lot and download big things, you're not wasting a ton of their bandwidth.

Now if that URL has changed over time (which I think did happen, as there was some discussion about audio quality on this episode), then it seems plausible that github actions might report nondeterministic file size fluctuations.

@jonhoo
Copy link
Collaborator

jonhoo commented Jun 21, 2020

Yeah, I also think that URL may have changed once, and suspect that some kind of caching is involved. But hard to figure out without observing it reproducably..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jonhoo @ericseppanen and others