-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI on unrelated PR fails with an error on episode 15 #58
Comments
This is so weird. It looks like the file size of that file keeps fluctuating? As far as I can tell, the correct size is |
I pushed a fix for that now. Let's see what CI does. |
Err, that seems to have passed... So strange.. |
This one seems wrong as well, but isn't throwing errors?
This is roughly what you get if there's a 404 trying to fetch the mp3 file. Note that curl doesn't return an error when this happens. (Maybe |
Ah, the episode 18 glitch is caused by there being a space after the URL. Curl is trying to fetch that and getting a 404. I'll play with the script a little bit to see if I can get it to fail in a less obscure way on 404 errors. |
Ah, yes, that would certainly do it! Thanks. |
Unfortunately, I don't think commit 78b9555 explains why the file size of episode 15 would have been fluctuating. As far as I can tell episode 18 had a completely separate glitch. |
Yeah, that's true.. I guess I'll re-open in case it shows up again. |
I wonder if there's some kind of intrusive caching layer within github, so if your CI scripts run a lot and download big things, you're not wasting a ton of their bandwidth. Now if that URL has changed over time (which I think did happen, as there was some discussion about audio quality on this episode), then it seems plausible that github actions might report nondeterministic file size fluctuations. |
Yeah, I also think that URL may have changed once, and suspect that some kind of caching is involved. But hard to figure out without observing it reproducably.. |
When queuing up a transcript for episode 008 (#57), I get a CI error:
This seems a little weird-- why don't I see this error on PR #55?
@nellshamrell any ideas? It seems to behave as though commit 92154b7 is backwards or not applied, or we're serving the wrong mp3 file?
The text was updated successfully, but these errors were encountered: