Clean up ctru-sys version checking #141
Conversation
- Don't issue a warning for "mismatched version" since the new bindings make this irrelevant - Minor build script refactoring and code cleanup - Output a `release` version (-X) for libctru env vars - Revert version to 0.5.0, which is higher than we were using before the major 22.x version but should be ok since we never released to crates.io
Also add a little extra description helper for unknown error types in ctru::error
Since the linker issues are fixed by previous changes we should be able to run CI without `--package` and test the whole workspace instead.
|
Nice PR. As i said regarding the bindings PR, I am convinced that |
No rush to review! With the way we're generating the bindings now I agreed in terms of version numbering, which is why I bumped it back down to 0.5.0. Most of the other stuff was just adding build script warnings and refactoring but feel free to review at your own pace 👍 |
|
I was able to figure out something that I think works a little better for linking |
`rustc-env` only works for the current crate, but plain keys work for dependent crates via the `DEP_CTRU` keys, which is probably more useful in general.
Relates to #100 but maybe not totally resolved by this PR
Don't issue a warning for "mismatched version" since the new bindings make this irrelevant
Minor build script refactoring and code cleanup
Output a
releaseversion (-X) for libctru env varsRevert version to 0.5.0, which is higher than we were using before the major 22.x version but should be ok since we never released to crates.io
Unconditionally link
ctru(notctrud) due to Is it necessary to modifyRUSTFLAGSincargo-3ds? cargo-3ds#14TODO I should update the README since it was documenting the version number convention but that also doesn't apply anymore