-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning of ctru-sys
crate
#100
Comments
Nice research! I really like the idea of the version number being related (we could specify this to the user in the README). I'm not an expert on GitHub CI, so I don't know the actual limitations, but retrieving |
As mentioned in #133 (comment) it sounds like we will probably move to a different versioning scheme than we had before, since that PR is now generating bindings on the fly instead of checking them into the repo. With those changes, I guess we can reset the I guess in principle, On a semi-related note, I was debating whether it might be worth it to wrap up the bindgen stuff that @FenrirWolf did into a separate crate so we could reuse it for |
Originally posted by @Meziu in #97 (comment)
This is an interesting idea I hadn't considered before! For inspiration I thought I'd look at some other
sys
crates, and I found this which looks kinda interesting: https://gitlab.com/taricorp/llvm-sys.rs#llvm-compatibilityBasically, we could have a
ctru-sys
version21.2.x
for the current release, and bump the minor version whenever we regenerate bindings for a new patch oflibctru
. This would also allow us to make docgen improvements, etc. as a patch version on the crate instead.In the case of
llvm-sys
, they have some checks in place to verify library versions at build time. It might be harder to do that withlibctru
, since it's just a static library, but I was thinking there might be some ways to check it withdkp-pacman
/pacman
, and spit out a build warning if the versions mismatch, which would be displayed if the build failed (link errors etc).Opening this issue to track + discuss the possibilities.
The text was updated successfully, but these errors were encountered: