Fix incorrect delta filtering #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
requested changes
Mar 3, 2024
kchibisov
approved these changes
Mar 4, 2024
kchibisov
force-pushed
the
notgull/delta2
branch
from
cdaffcc to
bb25e4b
Compare
Invert the mouse delta filter, so it aligns with the intention of filtering values lower than epsilon. Signed-off-by: John Nunley <[email protected]> Closes: #3558
kchibisov
force-pushed
the
notgull/delta2
branch
from
bb25e4b to
8c00428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the incorrect delta filtering. Due to a bug in the filtering
code, it would incorrectly filter out the correct mouse delta rather
than the one below zero. This fixes the order of events.
Closes #3558
CHANGELOG.mdif knowledge of this change could be valuable to users