Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse events regression in 0.29.12+ on X11 #3558

Closed
rafalh opened this issue Mar 2, 2024 · 1 comment · Fixed by #3559
Closed

Mouse events regression in 0.29.12+ on X11 #3558

rafalh opened this issue Mar 2, 2024 · 1 comment · Fixed by #3559
Assignees
@notgull
Labels
B - regression DS - x11

Comments

@rafalh
Copy link

rafalh commented Mar 2, 2024

Testing new the Bevy version 0.13 on Linux I encountered a mouse-look camera regression. I tracked it down to release 0.29.12 of winit.
On both videos I am trying to move my mouse horizontally and the only difference is winit version.

winit 0.29.12
https://github.com/rust-windowing/winit/assets/160391/4962b5ef-d626-4464-8911-70332a6c4cb3
winit 0.29.11
https://github.com/rust-windowing/winit/assets/160391/83ca6774-8234-4981-986e-8f3e616d96d9

In the first one horizontal movement is very slow and generally mouse moves in a diagonal motion. In the second it works as expected.
I think it may have been caused by 3d4c534

Likely related to bevyengine/bevy#12198
@tim-blackbird
Copy link

I left a comment on the specific lines I think are causing the issue: #3523 (comment)

@notgull notgull mentioned this issue Mar 2, 2024
Merged
5 tasks
kchibisov pushed a commit that referenced this issue Mar 4, 2024
@notgull @kchibisov
bugfix(x11): fix incorrect delta filtering
8c00428 
Invert the mouse delta filter, so it aligns with the intention of
filtering values lower than epsilon.

Signed-off-by: John Nunley <[email protected]>
Closes: #3558
kchibisov pushed a commit that referenced this issue Mar 4, 2024
@notgull @kchibisov
bugfix(x11): fix incorrect delta filtering
f6f1c45 
Invert the mouse delta filter, so it aligns with the intention of
filtering values lower than epsilon.

Signed-off-by: John Nunley <[email protected]>
Closes: #3558
kchibisov pushed a commit that referenced this issue Mar 5, 2024
@notgull @kchibisov
bugfix(x11): fix incorrect delta filtering
968956c 
Invert the mouse delta filter, so it aligns with the intention of
filtering values lower than epsilon.

Signed-off-by: John Nunley <[email protected]>
Closes: #3558
kchibisov pushed a commit that referenced this issue Mar 6, 2024
@notgull @kchibisov
bugfix(x11): fix incorrect delta filtering
7601a15 
Invert the mouse delta filter, so it aligns with the intention of
filtering values lower than epsilon.

Signed-off-by: John Nunley <[email protected]>
Closes: #3558
notgull added a commit that referenced this issue Mar 7, 2024
@notgull
bugfix(x11): fix incorrect delta filtering
f151689 
Invert the mouse delta filter, so it aligns with the intention of
filtering values lower than epsilon.

Signed-off-by: John Nunley <[email protected]>
Closes: #3558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notgull notgull

Labels
B - regression DS - x11
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect delta filtering rust-windowing/winit
4 participants
@rafalh @notgull @kchibisov @tim-blackbird