Fix macos memory leaks #2739
Merged
Fix macos memory leaks #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
B - bug
madsmtm
force-pushed
the
fix-macos-memory-leaks
branch
from
881a791 to
443064b
Compare
|
this seems to fix the leak and not crash in both my simple example and my complex Talon test |
|
Thanks @lunixbochs - I've tested it myself now as well. @kchibisov: Feel free to include this in the next patch version of |
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Mar 16, 2023
* Use a weak reference from WinitView to WinitWindow * Allow patched objc2 version * Add changelog entry
kchibisov
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Use a weak reference from WinitView to WinitWindow * Allow patched objc2 version * Add changelog entry
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2722 by patching
objc2instead, and using version ranges to allow the patched version to be selected.If the user has
accesskit_macosin their dependency tree, this will not work until @mwcampbell usesobjc2 = ">=0.3.0-beta.3, <0.3.0-beta.4"in that.Currently very limited internet, and having a few problems withcargo update, so I can't test this fully myself right now. I have tested that the version resolution works though!CHANGELOG.mdif knowledge of this change could be valuable to users