Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versions + stop using pre-release versioning #464

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jun 18, 2023

We're going to go away from using pre-release versions; while they're nice for signalling instability, they're a real pain when you need to do patch releases, see e.g. rust-windowing/winit#2739 (which is also why we skip objc2 v0.3).

While we release both objc2 v0.4 and block2 v0.2, these are not expected to be stable, and will still have frequent breaking changes. This is unfortunate, but unavoidable, and still better that we'd be able to patch these if e.g. winit requires it. I'll try to be harsher with objc2-encode v2 though, since users expect more stability from such a version number, but I will not let it severely hinder development.

Checklist:

  • The branch is named new-versions, such that the full CI will run.
  • Changelogs have only been modified under the Unreleased header.
  • Version numbers are bumped in the following order:
    • objc-sys
    • objc2-encode
    • objc2
    • block2
    • icrate
  • Local tests have been run (see helper-scripts/test-local.fish):
    • macOS 10.14.6 32bit
    • iOS 9.3.6, 1st generation iPad Mini
      • Am not at the same physical location, so will have to be skipped for now
  • Any errors that emerge have been fixed in other PRs

Post merge:

  • A tag is created on the merge commit for each new version.

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates A-framework Affects the framework crates and the translator for them labels Jun 18, 2023
@madsmtm madsmtm changed the title New versions New versions + stop using pre-release versioning Jun 18, 2023
@madsmtm madsmtm marked this pull request as ready for review June 20, 2023 18:31
@madsmtm madsmtm merged commit 97c2eba into master Jun 20, 2023
@madsmtm madsmtm deleted the new-versions branch June 20, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Affects the framework crates and the translator for them A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant