Add web support via stdweb and web-sys #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything typechecks, but nothing is implemented
Update the internal APIs to match the new API changes
* Stop appending canvas to document in web platform * Remove `tabindex` TODO in web backend * Return `OsError` instead of panicking on web canvas creation
* Add the plumbing for handling browser closes * Implement the business logic for handling closes
* Use actual numeric IDs to differentiate Windows This is generally important to identifying which window should recieve which event, but is also specifically crucial for fixing RedrawRequested on web. * Cargo fmt
* Keep track of what windows have requested redraw Instead of using request_animation_frame and sending redraw request events, just keep track of all windows that have asked for a redraw. This doesn't handle dispatching the events * Issue redraw events to windows that request it * Cargo fmt
* Update the documentation to reflect web support Indicate which methods have platform-specific web behavior * cargo fmt
Adds fullscreen using native web APIs to the stdweb and web-sys backends. Due to limitations of browser APIs, requests for fullscreen can only be fulfilled during a short-lived user-triggered event. This commit does automatically handle that under the hood, but it does introduce unavoidable latency in full-screening the canvas.
* Add web targets to travis * Fix some bash syntax * Avoid crash on providing no features * Fix syntax error * Syntax? * Fix pleas * Fix features check * Add a comment * Add nightly builds
|
@ryanisaacg Rebasing on the latest master should fix the Appveyor failure |
|
@Osspial should I squash and merge this, or merge from the CLI? |
|
@ryanisaacg Go ahead and merge from the CLI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to usersResolves #395