Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a LoopDestroyed event when the browser is closed #1155

Merged
merged 2 commits into from
Sep 11, 2019
Merged

Send a LoopDestroyed event when the browser is closed #1155

merged 2 commits into from
Sep 11, 2019

Conversation

ryanisaacg
Copy link
Contributor

@ryanisaacg ryanisaacg commented Sep 10, 2019 •
edited
Loading

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@ryanisaacg ryanisaacg mentioned this pull request Sep 10, 2019
Closed
10 tasks
@ryanisaacg ryanisaacg marked this pull request as ready for review September 10, 2019 18:10
@ryanisaacg
Copy link
Contributor Author

Looks like the CI failure is spurious and related to some nightly toolchain failure with rustfmt

@goddessfreya
Copy link
Contributor

goddessfreya commented Sep 11, 2019 •
edited
Loading

Ah, 03f9e8f prolly wasn't backported.

hecrj
hecrj approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ryanisaacg ryanisaacg merged commit e87bc3d into rust-windowing:web Sep 11, 2019
@ryanisaacg ryanisaacg deleted the on-close-event branch September 11, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanisaacg @goddessfreya @hecrj