Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused error-prone submodule setup #1575

Merged

Conversation

proletarius101
Copy link
Contributor

@proletarius101 proletarius101 commented Feb 15, 2023

According to https://git-scm.com/docs/gitsubmodules, there must be a working directory at path/to/bar/ if there's a submodule.foo.path = path/to/bar entry in .gitmodules. Failure to have this will result in errors in certain build environments (e.g. Flatpak: standardnotes/app#516)

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@kchibisov kchibisov requested a review from MarijnS95 February 15, 2023 16:09
@MarijnS95
Copy link
Member

Is this submodule even used? It points to a repository that has been archived for quite some time and is superseded by multiple tools.

@MarijnS95
Copy link
Member

Ah, @kchibisov also assigned me as reviewer, likely to check. No, I am not aware of any use of apk-builder, the CI uses cargo-apk which it installs ad-hoc (and the readme documents this for users. The submodule should be removed instead.

@proletarius101
Copy link
Contributor Author

Changed to remove that submodule
@MarijnS95

@proletarius101 proletarius101 changed the title fix: properly initialize the submodule fix: remove unused error-prone submodule setup Feb 16, 2023
proletarius101 added a commit to proletarius101/glutin that referenced this pull request Feb 16, 2023
According to https://git-scm.com/docs/gitsubmodules, there must be a working directory at path/to/bar/ if there's a submodule.foo.path = path/to/bar entry in .gitmodules. Failure to have this will result in errors in certain build environments (e.g. Flatpak: standardnotes/app#516)

Same as in rust-windowing#1575
@kchibisov kchibisov merged commit 966cf95 into rust-windowing:master Feb 16, 2023
@kchibisov
Copy link
Member

Ah, @kchibisov also assigned me as reviewer, likely to check. No, I am not aware of any use of apk-builder

Thanks, for confirming, that it's redundant. I also had a feeling that this file was just laying around without anyone noticing it.

@proletarius101 thanks for removing it :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants