-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FamStructWrapper: incorrect Clone implementation #85
Comments
I'm trying to understand this issue, please correct me if I'm wrong. A FAM struct, in the typical case, just has length and a bunch of entries. Therefore, in this case, the |
@Twister915 I find it to be the other way around. We already support other fields in FAM Struct, but the clone is implemented such that only the |
All the fields from the FamStruct shuld be cloned instead of just the len field and the entries slice. Fixes: rust-vmm#85. Signed-off-by: Laura Loghin <[email protected]>
All the fields from the FamStruct shuld be cloned instead of just the len field and the entries slice. Fixes: rust-vmm#85. Signed-off-by: Laura Loghin <[email protected]>
All the fields from the FamStruct shuld be cloned instead of just the len field and the entries slice. Fixes: rust-vmm#85. Signed-off-by: Laura Loghin <[email protected]>
Clone
implementation forFamStructWrapper
keeps only the number of entries and the entries array members. This implementation should be either removed or modified so that all fields are cloned.The text was updated successfully, but these errors were encountered: