Upgrade vmm-sys-util to 0.8.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
src/primitives.rs
Outdated
| // Update Default T with the deserialized header. | ||
| std::mem::replace(object.as_mut_fam_struct(), header); | ||
| let _ = std::mem::replace(object.as_mut_fam_struct(), header); |
There was a problem hiding this comment.
Can you assign the value directly since you are not doing anything with the previous value from the object?
Signed-off-by: Andrei Sandu <[email protected]>
sandreim
force-pushed
the
upgrade_vmm_sys_util
branch
from
831c3ac to
2f8eb04
Compare
Signed-off-by: Andrei Sandu <[email protected]>
AlexandruCihodaru
force-pushed
the
upgrade_vmm_sys_util
branch
from
2f8eb04 to
f3e6dd2
Compare
AlexandruCihodaru
force-pushed
the
upgrade_vmm_sys_util
branch
from
f3e6dd2 to
f7a1a1e
Compare
Signed-off-by: Alexandru Cihodaru <[email protected]>
AlexandruCihodaru
force-pushed
the
upgrade_vmm_sys_util
branch
from
f7a1a1e to
bd5eeb4
Compare
|
Maybe also update changelog or you can do that in release PR. |
georgepisaltu
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Upgrade to latest vmm-sys-util. Fixes rust-vmm/vmm-sys-util#85
Description of Changes
Provided in commit log.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.CHANGELOG.md.