-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfio-ioctls: Remove conditional compilation to x86_64 for mshv feature #43
Conversation
fe08f2b
to
1b61455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Here is the dependency chain that leads to toml_edit being pulled in
Might be worth adjusting the features used in mshv-bindings when depending on num_enum crate (see illicitonion/num_enum#18) or maybe drop that depenency if it's not really required. |
|
I have a PR to fix the problem on MSHV side: rust-vmm/mshv#139 |
I tested with the PR branch, and it seems to have fix the problem. Here is a link to test run: https://buildkite.com/rust-vmm/vfio-ioctls-ci/builds/253#018ebdaf-a57c-470c-ba10-3563d6ef2fc5 |
We are planning to add support for ARM64 on cloud hypervisor side. Thus, remove the conditional compilation for target_arch x86_64. Signed-off-by: Jinank Jain <[email protected]>
@rbradford Fix in mshv is merged and the pipeline is green now. |
Summary of the PR
We are planning to add support for ARM64 on cloud hypervisor side. Thus, remove the conditional compilation for target_arch x86_64.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.