mshv-bindings: Turn off default features for num_enum #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
num_enum with default features turned breaks the compilation of rust-vmm/vfio crate. error: package `toml_edit v0.21.1` cannot be built because it requires rustc 1.69 or newer, while the currently active rustc version is 1.67.1 Either upgrade to rustc 1.69 or newer, or use cargo update -p [email protected] --precise ver where `ver` is the latest version of `toml_edit` supporting rustc 1.67.1 🚨 Error: The command exited with status 101 Signed-off-by: Jinank Jain <[email protected]>
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
4 tasks
NunoDasNeves
approved these changes
Apr 8, 2024
russell-islam
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
num_enum with default features turned breaks the compilation of rust-vmm/vfio crate.
error: package
toml_edit v0.21.1cannot be built because it requires rustc 1.69 or newer, while the currently active rustc version is 1.67.1 Either upgrade to rustc 1.69 or newer, or usecargo update -p [email protected] --precise ver
where
veris the latest version oftoml_editsupporting rustc 1.67.1 🚨 Error: The command exited with status 101Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.