-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new OffsetPageTable
mapper type
#83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-published as version 0.7.2-beta.0 for experimentation. |
phil-opp
force-pushed
the
offset_page_table
branch
from
July 17, 2019 08:59
29ea359
to
a358d4c
Compare
A trait implementation for `Fn(PhysFrame) -> *mut PageTable` is provided, so this change shouldn't break any existing code.
The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`.
phil-opp
force-pushed
the
offset_page_table
branch
from
July 17, 2019 09:00
a358d4c
to
aef984b
Compare
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`. TODO: - [x] Make `phys_offset` a `VirtAddr` instead of an `u64` Fixes #81 Co-authored-by: Philipp Oppermann <[email protected]>
Canceled |
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`. TODO: - [x] Make `phys_offset` a `VirtAddr` instead of an `u64` Fixes #81 Co-authored-by: Philipp Oppermann <[email protected]>
Build succeeded
|
Published as version 0.7.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type wraps a
MappedPageTable
instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in astatic
.TODO:
phys_offset
aVirtAddr
instead of anu64
Fixes #81