Simplify MappedPageTable type?
#81
Comments
bors bot
added a commit
that referenced
this issue
Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`. TODO: - [x] Make `phys_offset` a `VirtAddr` instead of an `u64` Fixes #81 Co-authored-by: Philipp Oppermann <[email protected]>
bors bot
added a commit
that referenced
this issue
Jul 17, 2019
83: Add a new `OffsetPageTable` mapper type r=phil-opp a=phil-opp The type wraps a `MappedPageTable` instance with a simpler interface. It uses a simple phys-to-virt offset instead of being generic over a phys-to-virt closure, which makes it easier to e.g. store the type in a `static`. TODO: - [x] Make `phys_offset` a `VirtAddr` instead of an `u64` Fixes #81 Co-authored-by: Philipp Oppermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
MappedPageTableis generic over aPhysToVirtfunction (Fn(PhysFrame) -> *mut PageTable). This makes it quite awkward to use in statics (see phil-opp/blog_os#639 (comment)).The question is: Does anybody use anything other than a simple offset to implement this function? If not, we could replace the generic
PhysToVirtclosure with a simplephysical_memory_offsetinteger to make it much simpler.The text was updated successfully, but these errors were encountered: