Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct wrong comment. #374

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Correct wrong comment. #374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e33cabc
Correct wrong comment. Unlike the comment suggests, more descriptors …
Apr 9, 2022
77a152f
Update comment and cleanup doc links
josephlr Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/registers/segmentation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@ impl fmt::Debug for SegmentSelector {

/// Code Segment
///
/// The segment base and limit are unused in 64-bit mode. Only the L (long), D
/// (default operation size), and DPL (descriptor privilege-level) fields of the
/// descriptor are recognized. So changing the segment register can be used to
/// change privilege level or enable/disable long mode.
/// Most fields like the segment base and limit are unused in 64-bit mode.
/// Only the LONG_MODE, PRESENT, USER_SEGMENT, EXECUTABLE, DEFAULT_SIZE (default operand size)
/// and DPL_RING_3 (descriptor privilege-level) fields of the
/// descriptor are recognized by the CPU. Some of them (e.g. DEFAULT_SIZE) are required to hold
/// a specific value and can't be changed. Others like the DPL_RING_3 and LONG_MODE
/// can be used to change privilege level or enable/disable long mode.
josephlr marked this conversation as resolved.
Show resolved Hide resolved
#[derive(Debug)]
pub struct CS;

Expand Down