Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wrong comment. #374

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Correct wrong comment. #374

merged 2 commits into from
Apr 14, 2022

Conversation

prinzdezibel
Copy link

Unlike the comment suggests, more descriptor fields than mentioned in the comment are recognized by the CPU.

…fields than mentioned in the comment are recognized by the CPU
@josephlr
Copy link
Contributor

@phil-opp @Freax13 I fixed up the comment, feel free to merge this if it looks good to you.

@Freax13
Copy link
Member

Freax13 commented Apr 14, 2022

@phil-opp @Freax13 I fixed up the comment, feel free to merge this if it looks good to you.

I'd like to hear from @prinzdezibel first.

@prinzdezibel
Copy link
Author

Makes perfect sense to me. Thanks @Freax13 , @josephlr .

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your contribution!

@Freax13 Freax13 merged commit 9c340c5 into rust-osdev:master Apr 14, 2022
@prinzdezibel prinzdezibel deleted the doc2 branch April 14, 2022 12:41
@phil-opp phil-opp mentioned this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants