Use rustversion and remove const_fn! #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
|
Actually I just realized we don't need to deprecate the #[cfg_attr(feature = "const_fn", rustversion::attr(all(), const))] |
Signed-off-by: Joe Richey <[email protected]>
josephlr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commit cleanup some out-of-date documentation
The third commit uses the
rustversioncreate to make the methods from #352constif the user is on a new enough compiler version.The fourth commit removes the
const_fn!macro, and usesrustversionto just enable theGlobalDescriptorTableconst methods if theconst_fnfeature is selected.In theory, we could also remove/deprecate the
const_fnfeature, and just have the GDT methods be const unconditionally if the compiled on nightly. That's a more complicated question, so I'll leave it for a follow up PR.