Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const_fn: Remove stabilized features #352

Merged
merged 1 commit into from
Mar 24, 2022
Merged

const_fn: Remove stabilized features #352

merged 1 commit into from
Mar 24, 2022

Conversation

josephlr
Copy link
Contributor

Both const_fn_fn_ptr_basics and const_fn_trait_bound were stabilized
in Rust relese 1.61. We can't immediately remove the const_fn! quite
yet. 1.61 is not yet on stable, and even it were, removing them would
increase our MSRV to 1.61 (which we may or may not want to do in a patch
release).

See also: #262 (comment)

Signed-off-by: Joe Richey [email protected]

Both `const_fn_fn_ptr_basics` and `const_fn_trait_bound` were stabilized
in Rust relese 1.61. We can't immediately remove the `const_fn!` quite
yet. 1.61 is not yet on stable, and even it were, removing them would
increase our MSRV to 1.61 (which we may or may not want to do in a patch
release).

See also: #262 (comment)

Signed-off-by: Joe Richey <[email protected]>
@josephlr josephlr requested review from phil-opp and Freax13 March 24, 2022 08:05
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@josephlr josephlr merged commit 0e1587b into master Mar 24, 2022
@josephlr josephlr deleted the const_features branch March 24, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants