Removes ndk-glue + ndk-macro as part of #372 modularization #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ndk-glue and ndk-macro subdirectores have been split into a stand-alone repository at: https://github.com/rust-mobile/ndk-glue This is being done as part of the modularization effort described in issue rust-mobile#372 The stand-alone repository was filtered like this: ``` git clone https://github.com/newren/git-filter-repo git clone https://github.com/rust-windowing/android-ndk-rs.git ndk-glue cd ndk-glue py ../git-filter-repo/git-filter-repo \ --path ndk-glue --path ndk-macro \ --path ndk-examples --path-rename ndk-examples:examples \ --path LICENSE-APACHE --path LICENSE-MIT \ --path Cargo.toml --path rustfmt.toml \ --path .github --path .gitignore ``` The last commit in this repo that is included within the stand-alone repository is 107f03e Although ndk-glue is also being deprecated at the same time as splitting it out this commit doesn't make any README changes for this repo yet which will be addressed separately. For now the ndk-examples continue to use the ndk-glue crate (the 0.7 release) and the current plan is to move these examples to the cargo-apk crate where they will be ported to use `android-activity`
rib
force-pushed
the
split-out-ndk-glue
branch
from
7d2255c
to
50a1d5e
Compare
|
In addressing the last CI failure I've added a note that the ndk-examples are now using the 0.7 release of ndk-glue instead of the in-tree version. This requires a This doesn't look to port the examples away from ndk-glue at this point since the current idea is that the examples will actually be removed from this repo and instead maintained within the Even if we decide we want to keep a copy of these examples in this repo too, it seems reasonable to handle porting to android-activity separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ndk-glue and ndk-macro subdirectores have been split into a stand-alone repository at: https://github.com/rust-mobile/ndk-glue
This is being done as part of the modularization effort described in issue #372
The stand-alone repository was filtered like this:
The last commit in this repo that is included within the stand-alone repository is 107f03e
Although ndk-glue is also being deprecated at the same time as splitting it out this commit doesn't make any README changes for this repo yet which will be addressed separately.
For now the ndk-examples continue to use the ndk-glue crate (the 0.7 release) and the current plan is to move these examples to the cargo-apk crate where they will be ported to use
android-activity