-
Notifications
You must be signed in to change notification settings - Fork 111
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lock MSRV to 1.60 and validate in CI (#362)
* Lock MSRV to 1.60 and validate in CI Prevent inadvertently bumping MSRV in PRs by checking against MSRV in the CI, to disallow any large bumps without rationale. Rust 1.60 is 7 months old at the time of writing, and also required by `winit` which uses `android-ndk-rs`, hence must be compatible with it. This does not mean that we cannot bump MSRV at all, but we must remain a tad conservative; at the same time setting [`rust-version`] in the manifest provides everyone on Rust 1.56 and higher a helpful error message when their version is lower than what we require. [`rust-version`]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field * ndk-build: Bump quick-xml to 0.26 to solve accidental MSRV bump Git history suggests that `quick-xml` backed out of an (un?)intentional MSRV bump and is now back at Rust 1.46; well below our MSRV needed for `winit`.
- Loading branch information
Showing
9 changed files
with
24 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,6 +36,20 @@ jobs: | |
# also compile cleanly under this target. | ||
args: --all --all-targets --all-features --target aarch64-linux-android -- -Dwarnings | ||
|
||
check_msrv: | ||
name: Check MSRV (1.60.0) | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v1 | ||
- uses: dtolnay/[email protected] | ||
with: | ||
target: aarch64-linux-android | ||
- uses: actions-rs/cargo@v1 | ||
with: | ||
command: check | ||
# See comment above about using one of our supported targets. | ||
args: --workspace --all-targets --all-features --target aarch64-linux-android | ||
|
||
build: | ||
strategy: | ||
fail-fast: false | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters