Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct lifetime binder for elided lifetimes in path. #96559

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Use the correct lifetime binder for elided lifetimes in path. #96559

merged 2 commits into from
Apr 30, 2022

Conversation

cjgillot
Copy link
Contributor

Fixes #96540

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 29, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2022
petrochenkov
petrochenkov reviewed Apr 29, 2022
View reviewed changes
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2022

📌 Commit 6e349c7 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2022
@bors
Auto merge of rust-lang#96566 - Dylan-DPC:rollup-fo7rd98, r=Dylan-DPC
05c0738 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96390 (Switch JS code to ES6 - part 2)
 - rust-lang#96527 (RustWrapper: explicitly don't handle DXILPointerTyID)
 - rust-lang#96536 (rustdoc: fix missing method list for primitive deref target)
 - rust-lang#96559 (Use the correct lifetime binder for elided lifetimes in path.)
 - rust-lang#96560 (Remove unnecessary environment variable in cf-protection documentation)
 - rust-lang#96562 (Fix duplicate directory separator in --remap-path-prefix.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2003d83 into rust-lang:master Apr 30, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 30, 2022
@alice-i-cecile alice-i-cecile mentioned this pull request Apr 30, 2022
Closed
@cjgillot cjgillot mentioned this pull request Apr 30, 2022
Closed
@cjgillot cjgillot deleted the elided-path-fn branch April 30, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

regression from error on elided lifetime in path in -> impl Trait<...>
5 participants
@cjgillot @rust-highfive @petrochenkov @bors @rustbot